Title: [126758] trunk/Source/WebCore
Revision
126758
Author
[email protected]
Date
2012-08-27 07:15:13 -0700 (Mon, 27 Aug 2012)

Log Message

Web Inspector: filter out weak references from retainers tree
https://bugs.webkit.org/show_bug.cgi?id=95082

Reviewed by Yury Semikhatsky.

Weak references don't retain objects.

* inspector/front-end/HeapSnapshotGridNodes.js:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (126757 => 126758)


--- trunk/Source/WebCore/ChangeLog	2012-08-27 14:08:50 UTC (rev 126757)
+++ trunk/Source/WebCore/ChangeLog	2012-08-27 14:15:13 UTC (rev 126758)
@@ -1,3 +1,14 @@
+2012-08-27  Ilya Tikhonovsky  <[email protected]>
+
+        Web Inspector: filter out weak references from retainers tree
+        https://bugs.webkit.org/show_bug.cgi?id=95082
+
+        Reviewed by Yury Semikhatsky.
+
+        Weak references don't retain objects.
+
+        * inspector/front-end/HeapSnapshotGridNodes.js:
+
 2012-08-27  Philippe Normand  <[email protected]>
 
         [GStreamer][Qt] WebAudio support

Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js (126757 => 126758)


--- trunk/Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js	2012-08-27 14:08:50 UTC (rev 126757)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js	2012-08-27 14:15:13 UTC (rev 126758)
@@ -542,7 +542,7 @@
         var showHiddenData = WebInspector.settings.showHeapSnapshotObjectsHiddenProperties.get();
         var filter = "function(edge) {\n" +
                      "    return !edge.isInvisible()\n" +
-                     "        && (" + !tree.showRetainingEdges + " || (edge.node().id() !== 1 && !edge.node().isSynthetic()))\n" +
+                     "        && (" + !tree.showRetainingEdges + " || (edge.node().id() !== 1 && !edge.node().isSynthetic() && !edge.isWeak()))\n" +
                      "        && (" + showHiddenData + " || (!edge.isHidden() && !edge.node().isHidden()));\n" +
                      "}\n";
         var snapshot = this._isFromBaseSnapshot ? tree.baseSnapshot : tree.snapshot;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to