Title: [126799] trunk/Source/WebCore
- Revision
- 126799
- Author
- [email protected]
- Date
- 2012-08-27 14:49:43 -0700 (Mon, 27 Aug 2012)
Log Message
[V8] Clean up reportFatalError in V8DOMWindowShell.cpp
https://bugs.webkit.org/show_bug.cgi?id=95124
Reviewed by Eric Seidel.
We don't need a PLATFORM(CHROMIUM) ifdef because MemoryUsageSupport has
a stub implementation on non-Chromium platforms. These comments are out
of date. We've been "temporarily" calling CRASH here for as long as the
bindings have existed and we don't plan to stop.
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::reportFatalError):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (126798 => 126799)
--- trunk/Source/WebCore/ChangeLog 2012-08-27 21:37:37 UTC (rev 126798)
+++ trunk/Source/WebCore/ChangeLog 2012-08-27 21:49:43 UTC (rev 126799)
@@ -1,5 +1,20 @@
2012-08-27 Adam Barth <[email protected]>
+ [V8] Clean up reportFatalError in V8DOMWindowShell.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=95124
+
+ Reviewed by Eric Seidel.
+
+ We don't need a PLATFORM(CHROMIUM) ifdef because MemoryUsageSupport has
+ a stub implementation on non-Chromium platforms. These comments are out
+ of date. We've been "temporarily" calling CRASH here for as long as the
+ bindings have existed and we don't plan to stop.
+
+ * bindings/v8/V8DOMWindowShell.cpp:
+ (WebCore::reportFatalError):
+
+2012-08-27 Adam Barth <[email protected]>
+
[V8] Clean up V8DOMWindowShell's reportUncaughtException
https://bugs.webkit.org/show_bug.cgi?id=95126
Modified: trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp (126798 => 126799)
--- trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp 2012-08-27 21:37:37 UTC (rev 126798)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp 2012-08-27 21:49:43 UTC (rev 126799)
@@ -83,16 +83,8 @@
static void reportFatalError(const char* location, const char* message)
{
- // V8 is shutdown, we cannot use V8 api.
- // The only thing we can do is to disable _javascript_.
- // FIXME: clean up ScriptController and disable _javascript_.
- int memoryUsageMB = -1;
-#if PLATFORM(CHROMIUM)
- memoryUsageMB = MemoryUsageSupport::actualMemoryUsageMB();
-#endif
+ int memoryUsageMB = MemoryUsageSupport::actualMemoryUsageMB();
printf("V8 error: %s (%s). Current memory usage: %d MB\n", message, location, memoryUsageMB);
- // FIXME: We temporarily deal with V8 internal error situations
- // such as out-of-memory by crashing the renderer.
CRASH();
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
