Title: [126815] trunk/Source/_javascript_Core
Revision
126815
Author
[email protected]
Date
2012-08-27 16:05:40 -0700 (Mon, 27 Aug 2012)

Log Message

Remove use of ClassInfo from SpeculativeJIT::compileGetByValOnArguments
https://bugs.webkit.org/show_bug.cgi?id=95131

Reviewed by Filip Pizlo.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments): We don't need this speculation check. We can replace it
with an assert to guarantee this.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (126814 => 126815)


--- trunk/Source/_javascript_Core/ChangeLog	2012-08-27 23:03:03 UTC (rev 126814)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-08-27 23:05:40 UTC (rev 126815)
@@ -1,3 +1,14 @@
+2012-08-27  Mark Hahnenberg  <[email protected]>
+
+        Remove use of ClassInfo from SpeculativeJIT::compileGetByValOnArguments
+        https://bugs.webkit.org/show_bug.cgi?id=95131
+
+        Reviewed by Filip Pizlo.
+
+        * dfg/DFGSpeculativeJIT.cpp:
+        (JSC::DFG::SpeculativeJIT::compileGetByValOnArguments): We don't need this speculation check. We can replace it 
+        with an assert to guarantee this.
+
 2012-08-27  Oliver Hunt  <[email protected]>
 
         Remove opcode definition autogen for now

Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (126814 => 126815)


--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2012-08-27 23:03:03 UTC (rev 126814)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2012-08-27 23:05:40 UTC (rev 126815)
@@ -3131,14 +3131,7 @@
     if (!m_compileOkay)
         return;
     
-    if (!isArgumentsSpeculation(m_state.forNode(node.child1()).m_type)) {
-        speculationCheck(
-            BadType, JSValueSource::unboxedCell(baseReg), node.child1(),
-            m_jit.branchPtr(
-                MacroAssembler::NotEqual,
-                MacroAssembler::Address(baseReg, JSCell::classInfoOffset()),
-                MacroAssembler::TrustedImmPtr(&Arguments::s_info)));
-    }
+    ASSERT(modeAlreadyChecked(m_state.forNode(node.child1()), Array::Arguments));
     
     m_jit.loadPtr(
         MacroAssembler::Address(baseReg, Arguments::offsetOfData()),
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to