Title: [126858] trunk
Revision
126858
Author
[email protected]
Date
2012-08-28 02:03:20 -0700 (Tue, 28 Aug 2012)

Log Message

[Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html
https://bugs.webkit.org/show_bug.cgi?id=95054

Reviewed by Eric Seidel.

Source/WebCore:

Add missing files to the build for CSS_IMAGE_SET.

* Target.pri:

Tools:

Enable CSS_IMAGE_SET for the Qt build.

* qmake/mkspecs/features/features.pri:

LayoutTests:

Unskip layout tests for CSS_IMAGE_SET.

* platform/qt/Skipped:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (126857 => 126858)


--- trunk/LayoutTests/ChangeLog	2012-08-28 08:52:26 UTC (rev 126857)
+++ trunk/LayoutTests/ChangeLog	2012-08-28 09:03:20 UTC (rev 126858)
@@ -1,3 +1,14 @@
+2012-08-28  Simon Hausmann  <[email protected]>
+
+        [Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html
+        https://bugs.webkit.org/show_bug.cgi?id=95054
+
+        Reviewed by Eric Seidel.
+
+        Unskip layout tests for CSS_IMAGE_SET.
+
+        * platform/qt/Skipped:
+
 2012-08-28  Andrey Adaikin  <[email protected]>
 
         Web Inspector: [WebGL] Add a test to catch new WebGL context states parameters

Modified: trunk/LayoutTests/platform/qt/Skipped (126857 => 126858)


--- trunk/LayoutTests/platform/qt/Skipped	2012-08-28 08:52:26 UTC (rev 126857)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-08-28 09:03:20 UTC (rev 126858)
@@ -441,10 +441,6 @@
 css3/filters/filter-property.html
 css3/filters/filter-repaint.html
 
-# CSS image-set support not yet enabled (needs ENABLE_CSS_IMAGE_SET).
-fast/css/image-set-parsing.html
-fast/css/image-set-parsing-invalid.html
-
 # CSS shaders
 css3/filters/custom
 
@@ -2046,10 +2042,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=92733
 fast/block/positioning/056.html
 
-# [Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html
-# https://bugs.webkit.org/show_bug.cgi?id=95054
-fast/css/image-set-setting.html
-
 # ============================================================================= #
 # failing fonts tests
 # ============================================================================= #

Modified: trunk/Source/WebCore/ChangeLog (126857 => 126858)


--- trunk/Source/WebCore/ChangeLog	2012-08-28 08:52:26 UTC (rev 126857)
+++ trunk/Source/WebCore/ChangeLog	2012-08-28 09:03:20 UTC (rev 126858)
@@ -1,3 +1,14 @@
+2012-08-28  Simon Hausmann  <[email protected]>
+
+        [Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html
+        https://bugs.webkit.org/show_bug.cgi?id=95054
+
+        Reviewed by Eric Seidel.
+
+        Add missing files to the build for CSS_IMAGE_SET.
+
+        * Target.pri:
+
 2012-08-28  Pavel Feldman  <[email protected]>
 
         Web Inspector: introduce overlay page and migrate "paused in debugger" to it.

Modified: trunk/Source/WebCore/Target.pri (126857 => 126858)


--- trunk/Source/WebCore/Target.pri	2012-08-28 08:52:26 UTC (rev 126857)
+++ trunk/Source/WebCore/Target.pri	2012-08-28 09:03:20 UTC (rev 126858)
@@ -273,6 +273,7 @@
     css/CSSGradientValue.cpp \
     css/CSSImageValue.cpp \
     css/CSSImageGeneratorValue.cpp \
+    css/CSSImageSetValue.cpp \
     css/CSSImportRule.cpp \
     css/CSSInheritedValue.cpp \
     css/CSSInitialValue.cpp \
@@ -1195,6 +1196,7 @@
     rendering/style/StyleBackgroundData.cpp \
     rendering/style/StyleBoxData.cpp \
     rendering/style/StyleCachedImage.cpp \
+    rendering/style/StyleCachedImageSet.cpp \
     rendering/style/StyleCachedShader.cpp \
     rendering/style/StyleDeprecatedFlexibleBoxData.cpp \
     rendering/style/StyleFilterData.cpp \

Modified: trunk/Tools/ChangeLog (126857 => 126858)


--- trunk/Tools/ChangeLog	2012-08-28 08:52:26 UTC (rev 126857)
+++ trunk/Tools/ChangeLog	2012-08-28 09:03:20 UTC (rev 126858)
@@ -1,3 +1,14 @@
+2012-08-28  Simon Hausmann  <[email protected]>
+
+        [Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html
+        https://bugs.webkit.org/show_bug.cgi?id=95054
+
+        Reviewed by Eric Seidel.
+
+        Enable CSS_IMAGE_SET for the Qt build.
+
+        * qmake/mkspecs/features/features.pri:
+
 2012-08-27  Csaba Osztrogonác  <[email protected]>
 
         [Qt] Enable CSS sticky position

Modified: trunk/Tools/qmake/mkspecs/features/features.pri (126857 => 126858)


--- trunk/Tools/qmake/mkspecs/features/features.pri	2012-08-28 08:52:26 UTC (rev 126857)
+++ trunk/Tools/qmake/mkspecs/features/features.pri	2012-08-28 09:03:20 UTC (rev 126858)
@@ -27,6 +27,7 @@
     ENABLE_CSS_HIERARCHIES=0 \
     ENABLE_CSS_IMAGE_ORIENTATION=0 \
     ENABLE_CSS_IMAGE_RESOLUTION=0 \
+    ENABLE_CSS_IMAGE_SET=1 \
     ENABLE_CSS_REGIONS=1 \
     ENABLE_CSS_SHADERS=0 \
     ENABLE_CSS_STICKY_POSITION=1 \
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to