Title: [126871] trunk/Source/WebKit/blackberry
Revision
126871
Author
commit-qu...@webkit.org
Date
2012-08-28 06:02:52 -0700 (Tue, 28 Aug 2012)

Log Message

[BlackBerry] UpdateViewport uses wrong size for frameView
https://bugs.webkit.org/show_bug.cgi?id=95138

Patch by Andy Chen <andc...@rim.com> on 2012-08-28
Reviewed by Antonio Gomes.
Internally reviewed by Jakob Petsovits.

Use actual visible size instead of screen size when updating viewport size,
otherwise, frameView size would be too big.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::updateViewportSize):

Modified Paths

Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (126870 => 126871)


--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-08-28 13:00:00 UTC (rev 126870)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-08-28 13:02:52 UTC (rev 126871)
@@ -1567,10 +1567,11 @@
     if (!m_backingStore)
         return;
     ASSERT(m_mainFrame->view());
+    IntSize visibleSize = actualVisibleSize();
     if (setFixedReportedSize)
-        m_mainFrame->view()->setFixedReportedSize(actualVisibleSize());
+        m_mainFrame->view()->setFixedReportedSize(visibleSize);
 
-    IntRect frameRect = IntRect(scrollPosition(), viewportSize());
+    IntRect frameRect = IntRect(scrollPosition(), visibleSize);
     if (frameRect != m_mainFrame->view()->frameRect()) {
         m_mainFrame->view()->setFrameRect(frameRect);
         m_mainFrame->view()->adjustViewSize();

Modified: trunk/Source/WebKit/blackberry/ChangeLog (126870 => 126871)


--- trunk/Source/WebKit/blackberry/ChangeLog	2012-08-28 13:00:00 UTC (rev 126870)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-08-28 13:02:52 UTC (rev 126871)
@@ -1,5 +1,19 @@
 2012-08-28  Andy Chen  <andc...@rim.com>
 
+        [BlackBerry] UpdateViewport uses wrong size for frameView
+        https://bugs.webkit.org/show_bug.cgi?id=95138
+
+        Reviewed by Antonio Gomes.
+        Internally reviewed by Jakob Petsovits.
+
+        Use actual visible size instead of screen size when updating viewport size,
+        otherwise, frameView size would be too big.
+
+        * Api/WebPage.cpp:
+        (BlackBerry::WebKit::WebPagePrivate::updateViewportSize):
+
+2012-08-28  Andy Chen  <andc...@rim.com>
+
         [BlackBerry] Pseudo class "active" is broken
         https://bugs.webkit.org/show_bug.cgi?id=95142
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to