Title: [126891] trunk/Source/WebCore
- Revision
- 126891
- Author
- [email protected]
- Date
- 2012-08-28 10:40:19 -0700 (Tue, 28 Aug 2012)
Log Message
[GTK] Does not regenerate CSS-related sources when configuration changes
https://bugs.webkit.org/show_bug.cgi?id=94927
Reviewed by Eric Seidel.
In bug 94094 the gtk EWS consistently failed to build the patch. The
reason that happens is the .in files have not been touched, so the CSS
property names and value keywords sources are not regenerated. By
adding an explicit dependency on configure.ac and GNUmakefile.am the
problem is fixed (see bug 82465, attachment 160265).
* GNUmakefile.am: add explicit dependency from the CSS-related .in files
on configure.ac and WebCore's GNUmakefile.am
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (126890 => 126891)
--- trunk/Source/WebCore/ChangeLog 2012-08-28 16:53:57 UTC (rev 126890)
+++ trunk/Source/WebCore/ChangeLog 2012-08-28 17:40:19 UTC (rev 126891)
@@ -1,3 +1,19 @@
+2012-08-28 Gustavo Noronha Silva <[email protected]>
+
+ [GTK] Does not regenerate CSS-related sources when configuration changes
+ https://bugs.webkit.org/show_bug.cgi?id=94927
+
+ Reviewed by Eric Seidel.
+
+ In bug 94094 the gtk EWS consistently failed to build the patch. The
+ reason that happens is the .in files have not been touched, so the CSS
+ property names and value keywords sources are not regenerated. By
+ adding an explicit dependency on configure.ac and GNUmakefile.am the
+ problem is fixed (see bug 82465, attachment 160265).
+
+ * GNUmakefile.am: add explicit dependency from the CSS-related .in files
+ on configure.ac and WebCore's GNUmakefile.am
+
2012-08-28 Sheriff Bot <[email protected]>
Unreviewed, rolling out r126813.
Modified: trunk/Source/WebCore/GNUmakefile.am (126890 => 126891)
--- trunk/Source/WebCore/GNUmakefile.am 2012-08-28 16:53:57 UTC (rev 126890)
+++ trunk/Source/WebCore/GNUmakefile.am 2012-08-28 17:40:19 UTC (rev 126891)
@@ -802,6 +802,10 @@
webcore_cppflags += $(foreach define,$(feature_defines),-D$(define))
+$(WEBCORE_CSS_PROPERTY_NAMES): $(srcdir)/configure.ac $(srcdir)/Source/WebCore/GNUmakefile.am
+
+$(WEBCORE_CSS_VALUE_KEYWORDS): $(srcdir)/configure.ac $(srcdir)/Source/WebCore/GNUmakefile.am
+
DerivedSources/WebCore/CSSPropertyNames.cpp: DerivedSources/WebCore/CSSPropertyNames.h
DerivedSources/WebCore/CSSPropertyNames.h: $(WEBCORE_CSS_PROPERTY_NAMES) $(WebCore)/css/makeprop.pl
$(AM_V_GEN)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
