[webkit-changes] [126906] trunk/Source/JavaScriptCore

[ggaren]

Title: [126906] trunk/Source/_javascript_Core

Revision

126906

Author

gga...@apple.com

Date

2012-08-28 11:42:07 -0700 (Tue, 28 Aug 2012)

Log Message

GCC warning in JSActivation is causing Mac EWS errors
https://bugs.webkit.org/show_bug.cgi?id=95103

Reviewed by Sam Weinig.

Try to fix a strict aliasing violation by using bitwise_cast. The
union in the cast should signal to the compiler that aliasing between
types is happening.

* runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):

Modified Paths

• trunk/Source/_javascript_Core/ChangeLog
• trunk/Source/_javascript_Core/runtime/JSActivation.cpp

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (126905 => 126906)

--- trunk/Source/_javascript_Core/ChangeLog	2012-08-28 18:36:38 UTC (rev 126905)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-08-28 18:42:07 UTC (rev 126906)
@@ -1,5 +1,19 @@
 2012-08-28  Geoffrey Garen  <gga...@apple.com>
 
+        GCC warning in JSActivation is causing Mac EWS errors
+        https://bugs.webkit.org/show_bug.cgi?id=95103
+
+        Reviewed by Sam Weinig.
+
+        Try to fix a strict aliasing violation by using bitwise_cast. The
+        union in the cast should signal to the compiler that aliasing between
+        types is happening.
+
+        * runtime/JSActivation.cpp:
+        (JSC::JSActivation::visitChildren):
+
+2012-08-28  Geoffrey Garen  <gga...@apple.com>
+
         Build fix: svn add two files I forgot in my last patch.
 
 2012-08-27  Geoffrey Garen  <gga...@apple.com>

Modified: trunk/Source/_javascript_Core/runtime/JSActivation.cpp (126905 => 126906)

--- trunk/Source/_javascript_Core/runtime/JSActivation.cpp	2012-08-28 18:36:38 UTC (rev 126905)
+++ trunk/Source/_javascript_Core/runtime/JSActivation.cpp	2012-08-28 18:42:07 UTC (rev 126906)
@@ -71,7 +71,7 @@
     if (!registerArray)
         return;
 
-    visitor.copyAndAppend(reinterpret_cast<void**>(&registerArray), thisObject->registerArraySizeInBytes(), reinterpret_cast<JSValue*>(registerArray), thisObject->registerArraySize());
+    visitor.copyAndAppend(bitwise_cast<void**>(&registerArray), thisObject->registerArraySizeInBytes(), reinterpret_cast<JSValue*>(registerArray), thisObject->registerArraySize());
     thisObject->m_registerArray.set(registerArray, StorageBarrier::Unchecked);
     thisObject->m_registers = registerArray + thisObject->registerOffset();
 

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes