Title: [127018] trunk/Tools
- Revision
- 127018
- Author
- [email protected]
- Date
- 2012-08-29 10:42:16 -0700 (Wed, 29 Aug 2012)
Log Message
Update TestRunner API for web notifications
https://bugs.webkit.org/show_bug.cgi?id=95093
<rdar://problem/12179649>
Reviewed by Alexey Proskuryakov.
As it turns out the patch for this accidentally got squashed into the commit for
bug 95099 (r126909). This amendment patch adds some comments about the renaming
of the older TestRunner API for web notifications.
* DumpRenderTree/TestRunner.h:
(TestRunner):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (127017 => 127018)
--- trunk/Tools/ChangeLog 2012-08-29 17:40:40 UTC (rev 127017)
+++ trunk/Tools/ChangeLog 2012-08-29 17:42:16 UTC (rev 127018)
@@ -1,3 +1,18 @@
+2012-08-29 Jon Lee <[email protected]>
+
+ Update TestRunner API for web notifications
+ https://bugs.webkit.org/show_bug.cgi?id=95093
+ <rdar://problem/12179649>
+
+ Reviewed by Alexey Proskuryakov.
+
+ As it turns out the patch for this accidentally got squashed into the commit for
+ bug 95099 (r126909). This amendment patch adds some comments about the renaming
+ of the older TestRunner API for web notifications.
+
+ * DumpRenderTree/TestRunner.h:
+ (TestRunner):
+
2012-08-29 Sheriff Bot <[email protected]>
Unreviewed, rolling out r126972.
Modified: trunk/Tools/DumpRenderTree/TestRunner.h (127017 => 127018)
--- trunk/Tools/DumpRenderTree/TestRunner.h 2012-08-29 17:40:40 UTC (rev 127017)
+++ trunk/Tools/DumpRenderTree/TestRunner.h 2012-08-29 17:42:16 UTC (rev 127018)
@@ -136,7 +136,9 @@
JSRetainPtr<JSStringRef> platformName() const;
#endif
+ // Legacy here refers to the old TestRunner API for handling web notifications, not the legacy web notification API.
void ignoreLegacyWebNotificationPermissionRequests();
+ // Legacy here refers to the old TestRunner API for handling web notifications, not the legacy web notification API.
void simulateLegacyWebNotificationClick(JSStringRef title);
void grantWebNotificationPermission(JSStringRef origin);
void denyWebNotificationPermission(JSStringRef origin);
@@ -418,6 +420,7 @@
bool m_useDeferredFrameLoading;
bool m_shouldPaintBrokenImage;
bool m_shouldStayOnPageAfterHandlingBeforeUnload;
+ // FIXME 81697: This variable most likely will be removed once we have migrated the tests from fast/notifications to http/tests/notifications.
bool m_areLegacyWebNotificationPermissionRequestsIgnored;
bool m_customFullScreenBehavior;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
