[webkit-changes] [127023] trunk

Wed, 29 Aug 2012 11:14:37 -0700

Title: [127023] trunk
Revision
127023
Author
[email protected]
Date
2012-08-29 11:14:01 -0700 (Wed, 29 Aug 2012)

Log Message

[chromium] Link highlight should clear on page navigation.
https://bugs.webkit.org/show_bug.cgi?id=95129

Reviewed by James Robinson.

Modified WebViewImpl to clear link highlight when navigating to new url.

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::didCommitLoad):

LayoutTests:

* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-navigate.html: Added.
* platform/chromium-linux/compositing/gestures/resources/gesture-tapHighlight-simple-navigate-destination.html: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-navigate-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-navigate-expected.txt: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (127022 => 127023)


--- trunk/LayoutTests/ChangeLog	2012-08-29 18:09:26 UTC (rev 127022)
+++ trunk/LayoutTests/ChangeLog	2012-08-29 18:14:01 UTC (rev 127023)
@@ -1,3 +1,17 @@
+2012-08-29  W. James MacLean  <[email protected]>
+
+        [chromium] Link highlight should clear on page navigation.
+        https://bugs.webkit.org/show_bug.cgi?id=95129
+
+        Reviewed by James Robinson.
+
+        Modified WebViewImpl to clear link highlight when navigating to new url.
+
+        * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-navigate.html: Added.
+        * platform/chromium-linux/compositing/gestures/resources/gesture-tapHighlight-simple-navigate-destination.html: Added.
+        * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-navigate-expected.png: Added.
+        * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-navigate-expected.txt: Added.
+
 2012-08-29  Jessie Berlin  <[email protected]>
 
         ASSERTION FAILED: enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()) : WebCore::FloatRect WebCore::RenderGeometryMap::absoluteRect(const WebCore::FloatRect &) const

Added: trunk/LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-navigate.html (0 => 127023)


--- trunk/LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-navigate.html	                        (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-navigate.html	2012-08-29 18:14:01 UTC (rev 127023)
@@ -0,0 +1,37 @@
+<!DOCTYPE html>
+<html>
+<head>
+<script src=""
+</head>
+<body _onload_="runTest();">
+<div style="position: relative; left: 10px; top: 40px">
+<a href="" id="targetLink" style="-webkit-tap-highlight-color: rgba(0, 255, 0, 0.5)">Target Link.</a>
+</div>
+<!-- For this test to work, must put the translateZ(0) on a div other than the one containing the
+     highlighted link. This will force the highlight into the non-composited content host, which
+     may survive the navigation. -->
+<div style="position: relative; left: 10px; top: 70px; -webkit-transform: translateZ(0);">
+This test is not successful if this message appears.
+</div>
+<script>
+function runTest() {
+    var clientRect = document.getElementById('targetLink').getBoundingClientRect();
+    x = (clientRect.left + clientRect.right) / 2;
+    y = (clientRect.top + clientRect.bottom) / 2;
+    if (window.testRunner) {
+        testRunner.dumpAsText(true);
+        testRunner.waitUntilDone();
+    }
+
+    if (window.eventSender) {
+        eventSender.gestureTapDown(x, y);
+        // Force display of highlight before navigating to second page.
+        window.testRunner.display();
+        window.location = 'resources/gesture-tapHighlight-simple-navigate-destination.html';
+    } else {
+        debug("This test requires DumpRenderTree.");
+    }
+}
+</script>
+</body>
+</html>

Added: trunk/LayoutTests/platform/chromium-linux/compositing/gestures/resources/gesture-tapHighlight-simple-navigate-destination.html (0 => 127023)


--- trunk/LayoutTests/platform/chromium-linux/compositing/gestures/resources/gesture-tapHighlight-simple-navigate-destination.html	                        (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/compositing/gestures/resources/gesture-tapHighlight-simple-navigate-destination.html	2012-08-29 18:14:01 UTC (rev 127023)
@@ -0,0 +1,22 @@
+<!DOCTYPE html>
+<html>
+<head>
+<script src=""
+</head>
+<body _onload_="runTest();">
+<div style="-webkit-transform: translateZ(0); position: relative; left: 10px; top: 40px">
+<div style="position: relative; left: 10px; top: 70px">
+This test is successful if no transparent green rectangles are visible.
+</div>
+<script>
+function runTest() {
+    if (window.testRunner) {
+        window.testRunner.dumpAsText(true);
+        window.testRunner.notifyDone();
+    } else {
+        debug("This test requires DumpRenderTree.");
+    }
+}
+</script>
+</body>
+</html>

Added: trunk/LayoutTests/platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-navigate-expected.png (0 => 127023)


--- trunk/LayoutTests/platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-navigate-expected.png	                        (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-navigate-expected.png	2012-08-29 18:14:01 UTC (rev 127023)
@@ -0,0 +1,4 @@
+\x89PNG
+
+
+IHDR X')tEXtchecksum256035ca8aa633f8bdfaff0c1744fb98ܛE\xBF\xD2IDATx\x9C\xED\xDDk\x88\xD5u\xE2\xC7\xF1\xDFX\xA9\x8D4m\xCBt\xB14Iڢ\xACL˨\xB1\xA0\xA0l\x8A\x8D\x88}҃} A[\x84Š "\xD1r\xB7e\xAD\x88\xAED\xA5փ.mم\xACq\xCB,s3\xB4\xFB4N\xDA\xFC\xFE\xCE\xCEe~\xBA\x9FQ\xB3\xD7\xEB\xC1r<\xBF\xF3\xFB^~\xE77\xCD\xE78\xDBU\x96e@΄\xBD\xBD\x80\xFD\x8D\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@ظVW{+V\xAC8\xF1\xC4\x9BO9\xEF\xBC\xF3\xC6c%\xEC\xF9\xFFG;v\xEC\xB8馛z{{{{{\xEF\xBD\xF7\xDEQGǼ\xB0\x9DO緩\xDDm\xB3\xD7u\xF8\xF2\xACj\xB7\xF2}vG\xC0oMWY\x96\xF9A\xBB\xBAn\xB9喅N\x9C8\xB1\xAB\xAB\xAB,\xCB\xE1\xE1\xE1[o\xBD\xF5\xAE\xBB\xEE:\xFA\xE8\xA37o\xDE<\x93\xEE\xF7.\8\xFE\xFCs\xCF=w\xE5ʕ.\\xBF~}\xE3\xD1\xE9ӧoڴ\xA9Å\xED|:\xBFMc\xDE6\xFB\xACc\x8E9\xA6\xE5I~\xBD;\xF63\xE3X\xA7\x9Crʿ\xFF\xFD\x9E\xA2(j\x81U\xC5w\xDF}7\xFE\xFCիWO\x9E<y\xB7'\xAD\x8F6\xAE\xA7\xEC\x9Bf̘\xB1~\xFD\xFA\x83:\xA8\xE5\xD1\xE1\xE1\xE1\xCE\xB6\xF3\xE9\xBB\xE1W}aՋ/r\xEB\xF3\xB6\xD9g\xB5[\xF9\xAFwG\xC0~f\~D\xB8f͚Z]5:\xF4\xD0C׬Y3iҤ1O/\xCBrpp\xB0\xF9\xF9?\xFC\xB0\xCA썧\xEF\xC6)\xBBz4\xA5y\x96Q\xCFlڴ\xA9C\x8Dya;\x9F\xBE\xAB*^\xD8*\xF6\xCC\xE5m\\xFC^\\xFF\xFF\xF2\xF5\xB8Ǵ\@\xBB\x95W\xD9\xC0\xB0w>\xE4\xBE~\xFD\xFA\xB3\xCE:\xAB\xA7\xA7\xE7\x81(\xFE\xFF\xC7&\xEE\xBB\xEF\xBE\xEE\xEE\xEE뮻\xAE\xAB\xABk\xD4YW]uUQ]]]W^yeQ۷o\xFF\xF3\x9F\xFF\xDC\xDD\xDD={\xF6쁁\x81\x96\xA7\x8F:\xA5\xAE\xE2\x8C\xCDGk\x9F$\xABj|<22r\xD3M7\xFD\xEEw\xBF\x9B:u\xEA\xDF\xFF\xFE\xF7OVYv\xCByGFF?\xCDּ\x86f\xF5m6\x9E\xDE\xF8\x82\x95+W\x9Et\xD2I\xFC\xF19\xE7\x9C\xD3\xD3ӳlٲ\xFA\xA1\xA7\x9Ezj\xEAԩ\xBD\xBD\xBD\xFB\xDBߚGn\xBC\xB0\xB5A\xEE\xBF\xFF\xFE#\x8F<r޼yEQ\xFC\xF3\x9F\xFF\x9C9s\xE6A4mڴ\xA5K\x97v\x98h\xD46W\xADZ5k֬w\xDF}\xF7\xF4\xD3O\x9F2e\xCAc\x8F=V\x9F\xB1ݘ\x8D\xF36_ۖ\xF3\xB6\xBB+\x8A\xA2\xE8\xEF\xEF?\xFB\xEC\xB3'M\x9At\xF5\xD5W\xEFܹ\xB3\xE2,էn\xBE\xF8c\x8E\xDC|\x8DZ\xF5\xABݼ\xBBF\xEF\xCCF\xBB\xF7\xA6ԭZ\xB5\xAAvO\xFC\xF1EQ\{\x{DD75}?>\xFE\xF8\xE3\xED\xBE<G}\xC4\xEA\xB5\xD7^\x9B5k\xD6a\x87\xB6dɒ\xE6\xE5u\x98`ܕ\xE3\xACy\x8A\xA2(/^\xFC\xCD7߬\\xB9򨣎*\xCBr\xEAԩ\xF5\x97\xF5\xF4\xF4lذ\xE1\x99g\x9Ei\xB9\xB6\xC6'o\xBC\xF1Ƈzh\xFB\xF6\xED+V\xAC\xB8\xE4\x92Kڝ\xDEr\x9C\xEA3\x8E:\xBAaÆ\xFA\xCB\xFE\xF3\x9F\xFF\xD4\xDFq\xC7w\xDEy\xE7\xD0\xD0\xD0\xF2\xE5ˏ;\xEE\xB8OV\v\x87\x8D\xB4[C\xF3\xFA\xB7\xD9\xE1:,^\xBCx۶m/\xBC\xF0Booo\xED\xF9\xB7\xDEz\xEB\xC2/ܺu\xEBK/\xBDt衇\xBE\xF2\xCA+\xCD\xE7\xD6<\xFC\xF0Ë\xA2x\xEE\xB9\xE7ꇎ=\xF6؍7\xEEر\xE3_\xFF\xFAה)S:L4j\x9BGqDQ˖-\xFB\xEE\xBB\xEF>\xF9\xE4\x93s\xCF=\xF7\xD9g\x9Fm7f\xF3\xBC\xCD׶ݼ\xED\xEE\xFC\xD3N;\xED\xD1G\\xB4hQQ|p\x95Yvi꺊#\xB7\xBC\x8B\xD7_\xFDj7\xEF\xAEq\xA8\x8Awf\xA3\xDD{Smݺ\xF5\xF2\xCB/*\xCBrǎ}}}\xC3\xC3\xC3\xBE<G\xDDҵ\xED\xAC[\xB7\xEE\x9Cs\xCEy\xE2\x89'F]\x9C\xCES\x8C\xAB\xBDX\xB5;w\xEE\x9C0aBY\x96CCC\xF5'O:\xE9\xA4e˖\xEDرc\xCCѦM\x9BV\xCF\xC4\xEE\xEE\xEEv\xA7\xB7\xFC\xC6P}\xC6\xCE\xD6Ϙ1\xE3\x9Bo\xBEun\xCB'+.\xBB⼍\x8F\x9Bwڸ͖\xD7a\xFB\xF6\xED\x8DoG\xFD\xF1\xFC\xF9\xF37l\xD8P{\xBC|\xF9\xF2SN9\xA5\xF9\xDC\xFA\x8Bi\xF9\x81\x983gN\xEDP\xBB\x89Fm\xB3\xF6\x93\xA0\xFA \xABW\xAF\xFE\xC3\xFEPe̚\xE6k\xDBn\xDEv\x81\xD5\xDD\xDD]\xFBf\xFF\xD3O?͚5\xAB\xE2,\xBB4u\xE3v\xAA\x8C\xDC\xF2.ubūݼ\xBBơ*ޙͻ\xD8\xD57e\x94믿\xFE\xBD\xF7\xDE+\xCB\xF2\xF5\xD7_\xBF\xF9\xE6\x9Bˎ_\x9E\xEDn\xE9\xFE\xFE\xFE\xB9s\xE7V\xD9\xC0\x9E\xB17\xABl7n\xBC\xFA\xEA\xABgΜ\xF9\xC6otmҤI\xCD/h>\xBDݷҊ3v\xB0\xFE\xF8\x80h>\xB7\xE5\x93\x97]q޲c`\x8Dy\xB4\xDDP'N\xAC=\xFE\xF1\xC7[\xAE\xB9\xDDzʲ|\xE7\x9Dw\xE6͛\xB7hѢ\xB5k׶\@\x87\x8B\xDF\xF8\xB2\x9F\xFE\xB9>\xF5\x98c\x96m\xAEm\xF5kU\x96\xE5\x82n\xBF\xFD\xF6\xC1\xC1\xC1'\x9Ex\xE2\xF0\xC3\xAF>ˮ^\xA2\xEA#\xB7\xBC\x8BO\xAC~\xB5;\xEF\xAE\xE2\x9D\xD9h\xB7ߔFo\xBE\xF9\xE6u\xD7]W\x96\xE55\xD7\\xB3z\xF5\xEAQ\x83t\xB8CF\xDD*\xB5϶\x8F\xB9#\x80=c\x9F\xAC\x9A\x97_~yƌ\x9DG\x9B3gN\xFD\xF1#\x8F<\xD2\xEE\xF4*a\xD1aƖ\x8E\x8C\x8C\xD4\x97e\xD9\xDBۻs\xE7\xCEQg\xB5|\xB2\xE2\xB2;o\xA4\xE5\x82\x815gΜ\xA7\x9F~\xBA\xF6x˖-\pA\xC5kfΜ\xB9v\xEDڲ,\xB7m\xDB\xD6\xF9[~\xCBm\xFE\xFC\xF3ϵ\xC7\xB3gϮ8f\xD9\xE6\xDA\xEER`\xBD\xFF\xFE\xFB}}}\x93'O>\xF1\xC4_|\xF1\xC5\xEA\xB3T\x9F\xBAQ\x95\x91[\xDEE\x8D'V\xBFڝw\xB7Kwfũ;[7k֬\xFE\xFE\xFE\xFA_\xAA5\xD2\xF2\xA1\xF15\xEF\xBE\xFB\xEE\x99g\x9EY}G\xE3m?\xE4^\x96\xE5\xEAի\x8B\xA2x\xFB\xED\xB7GFFjO~\xF6\xD9gEQl޼\xB9(\x8A-[\xB6E\xB1iӦ\xCF?\xFF\xBC(\x8A\xDA\xFFvuu=\xF5\xD4SӦM\xFB\xF1\xC7\x9B\xC7<\xF0\xC0_\xFD\xF5SO=\xB5(\x8AK/\xBD\xF4\xA1\x87|\xFC\xF1\xC7}\xF4\xD1\xDA\x9AOo<\xA5\xAE\xFA\x8C\xCDG\xFF\xFB߿\xF8\xE2\x8B\xDF~\xFB\xED\xE2ŋ\x8B\xA2\x989sfQ_|񫯾:22\xD2\xDF\xDF_\xFB\xC4n\xBB'+.{\xD43\x9B6m*\x8A\xE2\xBD\xF7\xDEk\xB7\x86\xDA^\xBE\xF8⋖\xDBuzݧ\x9F~Z;\xFE\xFB\xDF\xFF\xD6'Z\xB2dɍ7\xDE\xF8\xD6[o}\xF5\xD5W7\xDCp\xC3\xDDw\xDF\xDDὨ\x9D2<<\?\xF4\xF5\xD7_\xF7\xF7\xF7o޼\xF9\xE1\x87\x9E0a\xC2\xD0\xD0P\xBB\x89Z^\xFC\x9Bo\xBE\xF9\x87~ؼy\xF3\x82\xFE\xFA׿\xB6\xB3y\xDE\xE6k\xDBnޖwEQ\xFAӟ\x9E|\xF2ɡ\xA1\xA1\xB5k\xD7^|\xF1\xC5\xF5\xD7w\x9Ee\x97\xA6\xAE\xAB8r˻\xA8q\xFDկv\xF3\xEEo\x9B\x8Awf\xA3\xDD{S\x9A]q\xC5\x97_~\xF9\xFF\xF8\xC7\xDA;|y6\x9A2eʃ>888800\xF0\x97\xBF\xFC\xE5\xB6\xDBn\xAB\xB2#\x80=d\xFCڭ\xE5D\x8Dl\xB9\x98\xA2(\xFE\xF1\x8F\xF4\xF4\xF4,]\xBA\xB4y\xCCk\xAF\xBD\xF6\xB0\xC3{\xF9\xE5\x97˲\xFC\xFE\xFBﯸ⊉'Ν;wݺu\xF5\xF1G\x9D\xDExJ\xF3\xDAƜ\xB1\xF9\xE8=\xF7\xDC3eʔ3\xCE8c``\xE0\x84Nx\xE1\x85ʲܲe\xCBE]4y\xF2\xE4\xB9s\xE7>\xFC\xF0õW\xB6|\xB2\xE2\xB2G=3\xEA*5\xAF\xA1\xE5:\xE6;\xDE\xF2\xED\xA8Z\xBAti\xED_\xAE=\xF9\xE4\x93-\xDF\xDF\xFA\x85\xAD\x9D5}\xFA\xF4\xFA\xA1ŋwww\x9Fu\xD6Y\xDF~\xFB\xED\xC9'\x9F\\x8F\xA4\xE6\x89Zn\xBC\xF6ǦM\x9B\xB6dɒ1\xC7l\x9C\xB7\xF9ڶ\x9B\xB7\xE5]Q\x96\xE5\xFC\xF9\xF3\xEB/;\xE4\x90Cj\xFF\xCAu\xCCYvi\xEAQ̑[\xDEE\x8D\xEB\xAF~\xB5\xDB\xED\xAEv\xB4\xE2\x9D\xD9h\xF7ޔf}\xF4QQ\xB5Obu\xBEC\xBD\xF3\xCE;}}}'N\x9C={\xF6\xF3\xCF?\xDF|n˩\xFB\xFA\xFAZ\xAE \xEB\xD7\xFD\xEB\xD9\xFF\xEC\xC5_\xFA\xC1lݺ\xF5\x82.(\x8A\xE2\x97_~Y\xB3fM__\xDF\xDE\xFDPA\xFB\xF7\xEE\xF65\xFEϞه\xD4~j\xFC\xE5\x97_\xEE\x95\xD9/\xBB첁\x81\x81m۶\x95e\xF9\xFD\xF7߿\xFA꫗]v\xD9^Y\xC9xؿw\xB0\xAFX\xECC\x8E:ꨢ(j\xBF\xEBhϻ\xF7\xDE{\x97/_>}\xFA\xF4I\x93&͛7o\xE3ƍ\xF5_\xBBؿw\xB0\xAF\xF1#B\x800\x83&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x80\xB0-Z\xB4\xB7\xD7\xF0\xABq\xFE\xF9\xE7\x8F\xF9\x83&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa \xEC\xFF\xD7\xFB\xA3\xD9\xCA\xC9IEND\xAEB`\x82
\ No newline at end of file

Added: trunk/LayoutTests/platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-navigate-expected.txt (0 => 127023)


--- trunk/LayoutTests/platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-navigate-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-navigate-expected.txt	2012-08-29 18:14:01 UTC (rev 127023)
@@ -0,0 +1 @@
+This test is successful if no transparent green rectangles are visible.

Modified: trunk/Source/WebKit/chromium/ChangeLog (127022 => 127023)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-08-29 18:09:26 UTC (rev 127022)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-08-29 18:14:01 UTC (rev 127023)
@@ -1,3 +1,15 @@
+2012-08-29  W. James MacLean  <[email protected]>
+
+        [chromium] Link highlight should clear on page navigation.
+        https://bugs.webkit.org/show_bug.cgi?id=95129
+
+        Reviewed by James Robinson.
+
+        Modified WebViewImpl to clear link highlight when navigating to new url.
+
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::didCommitLoad):
+
 2012-08-29  James Robinson  <[email protected]>
 
         [chromium] CCThreadImpl / WebCompositorImpl shouldn't compile from webkit when use_libcc_for_compositor=1

Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (127022 => 127023)


--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-08-29 18:09:26 UTC (rev 127022)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-08-29 18:14:01 UTC (rev 127023)
@@ -3443,6 +3443,8 @@
     if (*isNewNavigation && !isNavigationWithinPage)
         m_pageScaleFactorIsSet = false;
 
+    // Make sure link highlight from previous page is cleared.
+    m_linkHighlight.clear();
     m_gestureAnimation.clear();
     resetSavedScrollAndScaleState();
 }

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to