Title: [127086] trunk/Source/WebKit/blackberry
- Revision
- 127086
- Author
- [email protected]
- Date
- 2012-08-29 19:49:41 -0700 (Wed, 29 Aug 2012)
Log Message
[BlackBerry] Do not use the shadow tree when retrieving the underlying element for FatFinger.
https://bugs.webkit.org/show_bug.cgi?id=95372
By using the shadow tree we were getting a mismatch between elements of the
current element under focus and the one return to us from FatFingers.
Passing ShadowContentNotAllowed to get the right handle.
Patch by Nima Ghanavatian <[email protected]> on 2012-08-29
Reviewed by Antonio Gomes.
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (127085 => 127086)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-08-30 02:24:41 UTC (rev 127085)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-08-30 02:49:41 UTC (rev 127086)
@@ -1,3 +1,17 @@
+2012-08-29 Nima Ghanavatian <[email protected]>
+
+ [BlackBerry] Do not use the shadow tree when retrieving the underlying element for FatFinger.
+ https://bugs.webkit.org/show_bug.cgi?id=95372
+
+ By using the shadow tree we were getting a mismatch between elements of the
+ current element under focus and the one return to us from FatFingers.
+ Passing ShadowContentNotAllowed to get the right handle.
+
+ Reviewed by Antonio Gomes.
+
+ * WebKitSupport/TouchEventHandler.cpp:
+ (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
+
2012-08-29 Robin Cao <[email protected]>
[BlackBerry] Move the handling of UserMedia requests to the client
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp (127085 => 127086)
--- trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp 2012-08-30 02:24:41 UTC (rev 127085)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp 2012-08-30 02:49:41 UTC (rev 127086)
@@ -229,7 +229,9 @@
bool shouldRequestSpellCheckOptions = false;
if (m_lastFatFingersResult.isTextInput())
- shouldRequestSpellCheckOptions = m_webPage->m_inputHandler->shouldRequestSpellCheckingOptionsForPoint(point.m_pos, m_lastFatFingersResult.nodeAsElementIfApplicable(), spellCheckOptionRequest);
+ shouldRequestSpellCheckOptions = m_webPage->m_inputHandler->shouldRequestSpellCheckingOptionsForPoint(point.m_pos
+ , m_lastFatFingersResult.nodeAsElementIfApplicable(FatFingersResult::ShadowContentNotAllowed)
+ , spellCheckOptionRequest);
// Apply any suppressed changes. This does not eliminate the need
// for the show after the handling of fat finger pressed as it may
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
