Title: [127090] trunk/Source/_javascript_Core
Revision
127090
Author
[email protected]
Date
2012-08-29 20:23:35 -0700 (Wed, 29 Aug 2012)

Log Message

Remove use of ClassInfo from compileGetByValOnArguments and compileGetArgumentsLength
https://bugs.webkit.org/show_bug.cgi?id=95131

Reviewed by Filip Pizlo.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments): We don't need this speculation check. We can replace it
with an assert to guarantee this.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (127089 => 127090)


--- trunk/Source/_javascript_Core/ChangeLog	2012-08-30 03:22:40 UTC (rev 127089)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-08-30 03:23:35 UTC (rev 127090)
@@ -1,3 +1,14 @@
+2012-08-29  Mark Hahnenberg  <[email protected]>
+
+        Remove use of ClassInfo from compileGetByValOnArguments and compileGetArgumentsLength
+        https://bugs.webkit.org/show_bug.cgi?id=95131
+
+        Reviewed by Filip Pizlo.
+
+        * dfg/DFGSpeculativeJIT.cpp:
+        (JSC::DFG::SpeculativeJIT::compileGetByValOnArguments): We don't need this speculation check. We can replace it 
+        with an assert to guarantee this.
+
 2012-08-29  Mark Lam  <[email protected]>
 
         Refactoring LLInt::Data.

Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (127089 => 127090)


--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2012-08-30 03:22:40 UTC (rev 127089)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2012-08-30 03:23:35 UTC (rev 127090)
@@ -3062,16 +3062,9 @@
     
     if (!m_compileOkay)
         return;
+  
+    ASSERT(modeAlreadyChecked(m_state.forNode(node.child1()), Array::Arguments));
     
-    if (!isArgumentsSpeculation(m_state.forNode(node.child1()).m_type)) {
-        speculationCheck(
-            BadType, JSValueSource::unboxedCell(baseReg), node.child1(),
-            m_jit.branchPtr(
-                MacroAssembler::NotEqual,
-                MacroAssembler::Address(baseReg, JSCell::classInfoOffset()),
-                MacroAssembler::TrustedImmPtr(&Arguments::s_info)));
-    }
-    
     m_jit.loadPtr(
         MacroAssembler::Address(baseReg, Arguments::offsetOfData()),
         scratchReg);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to