Title: [127104] trunk/Tools
- Revision
- 127104
- Author
- [email protected]
- Date
- 2012-08-29 23:19:25 -0700 (Wed, 29 Aug 2012)
Log Message
Random test-webkitpy failures on the buildbot
https://bugs.webkit.org/show_bug.cgi?id=95096
Reviewed by Dirk Pranke.
Suppress occasional errors when running test-webkitpy on GTK builders
by running these tests serially. The 64-bit Release builder is especially
prone to these as it can run up to 24 tests in parallel.
Despite the tests not being run in parallel, the testing only lasts a handful
of seconds more, so this is a worthy trade-off to avoid unnecessary
false-alarm redness on the GTK builders.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunPythonTests.start):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (127103 => 127104)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-08-30 05:50:39 UTC (rev 127103)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-08-30 06:19:25 UTC (rev 127104)
@@ -457,6 +457,14 @@
command = ["python", "./Tools/Scripts/test-webkitpy"]
failedTestsFormatString = "%d python tests failed"
+ def start(self):
+ platform = self.getProperty('platform')
+ # Python tests are flaky on the GTK builders, running them serially
+ # helps and does not significantly prolong the cycle time.
+ if platform == 'gtk':
+ self.setCommand(self.command + ['--child-processes', '1'])
+ return shell.Test.start(self)
+
def countFailures(self, cmd):
logText = cmd.logs['stdio'].getText()
# We're looking for the line that looks like this: FAILED (failures=2, errors=1)
Modified: trunk/Tools/ChangeLog (127103 => 127104)
--- trunk/Tools/ChangeLog 2012-08-30 05:50:39 UTC (rev 127103)
+++ trunk/Tools/ChangeLog 2012-08-30 06:19:25 UTC (rev 127104)
@@ -1,3 +1,21 @@
+2012-08-29 Zan Dobersek <[email protected]>
+
+ Random test-webkitpy failures on the buildbot
+ https://bugs.webkit.org/show_bug.cgi?id=95096
+
+ Reviewed by Dirk Pranke.
+
+ Suppress occasional errors when running test-webkitpy on GTK builders
+ by running these tests serially. The 64-bit Release builder is especially
+ prone to these as it can run up to 24 tests in parallel.
+
+ Despite the tests not being run in parallel, the testing only lasts a handful
+ of seconds more, so this is a worthy trade-off to avoid unnecessary
+ false-alarm redness on the GTK builders.
+
+ * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+ (RunPythonTests.start):
+
2012-08-29 Benjamin Poulain <[email protected]>
REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
