Title: [127116] trunk/Source/WebCore
- Revision
- 127116
- Author
- [email protected]
- Date
- 2012-08-30 02:06:43 -0700 (Thu, 30 Aug 2012)
Log Message
Web Inspector: [Sources] Invisible right sidebar issue
https://bugs.webkit.org/show_bug.cgi?id=94924
Reviewed by Pavel Feldman.
Debugger sidebar resizer is now hidden when sidebar is hidden.
Debugger sidebar show button is moved to the upper right corner in this case.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._showDebuggerSidebar):
(WebInspector.ScriptsPanel.prototype.set _hideDebuggerSidebar):
* inspector/front-end/scriptsPanel.css:
(button.status-bar-item.scripts-debugger-show-hide-button):
(button.status-bar-item.scripts-debugger-show-hide-button:active):
(button.status-bar-item.scripts-debugger-show-hide-button.toggled-shown):
(button.status-bar-item.scripts-debugger-show-hide-button.toggled-shown:active):
(button.status-bar-item.scripts-debugger-show-hide-button.toggled-hidden):
(button.status-bar-item.scripts-debugger-show-hide-button.toggled-hidden:active):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (127115 => 127116)
--- trunk/Source/WebCore/ChangeLog 2012-08-30 09:01:39 UTC (rev 127115)
+++ trunk/Source/WebCore/ChangeLog 2012-08-30 09:06:43 UTC (rev 127116)
@@ -1,3 +1,24 @@
+2012-08-30 Vsevolod Vlasov <[email protected]>
+
+ Web Inspector: [Sources] Invisible right sidebar issue
+ https://bugs.webkit.org/show_bug.cgi?id=94924
+
+ Reviewed by Pavel Feldman.
+
+ Debugger sidebar resizer is now hidden when sidebar is hidden.
+ Debugger sidebar show button is moved to the upper right corner in this case.
+
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype._showDebuggerSidebar):
+ (WebInspector.ScriptsPanel.prototype.set _hideDebuggerSidebar):
+ * inspector/front-end/scriptsPanel.css:
+ (button.status-bar-item.scripts-debugger-show-hide-button):
+ (button.status-bar-item.scripts-debugger-show-hide-button:active):
+ (button.status-bar-item.scripts-debugger-show-hide-button.toggled-shown):
+ (button.status-bar-item.scripts-debugger-show-hide-button.toggled-shown:active):
+ (button.status-bar-item.scripts-debugger-show-hide-button.toggled-hidden):
+ (button.status-bar-item.scripts-debugger-show-hide-button.toggled-hidden:active):
+
2012-08-30 Ilya Tikhonovsky <[email protected]>
Web Inspector: move GeneratedImage members into its own cpp file
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (127115 => 127116)
--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2012-08-30 09:01:39 UTC (rev 127115)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2012-08-30 09:06:43 UTC (rev 127116)
@@ -990,6 +990,7 @@
this._toggleDebuggerSidebarButton.state = "shown";
this._toggleDebuggerSidebarButton.title = WebInspector.UIString("Hide debugger");
this.splitView.showSidebarElement();
+ this.debugSidebarResizeWidgetElement.removeStyleClass("hidden");
WebInspector.settings.debuggerSidebarHidden.set(false);
},
@@ -1000,6 +1001,7 @@
this._toggleDebuggerSidebarButton.state = "hidden";
this._toggleDebuggerSidebarButton.title = WebInspector.UIString("Show debugger");
this.splitView.hideSidebarElement();
+ this.debugSidebarResizeWidgetElement.addStyleClass("hidden");
WebInspector.settings.debuggerSidebarHidden.set(true);
},
Modified: trunk/Source/WebCore/inspector/front-end/scriptsPanel.css (127115 => 127116)
--- trunk/Source/WebCore/inspector/front-end/scriptsPanel.css 2012-08-30 09:01:39 UTC (rev 127115)
+++ trunk/Source/WebCore/inspector/front-end/scriptsPanel.css 2012-08-30 09:06:43 UTC (rev 127116)
@@ -258,7 +258,6 @@
button.status-bar-item.scripts-debugger-show-hide-button {
position: absolute;
top: 0;
- right: 16px;
background-image: none;
height: 16px;
width: 16px;
@@ -268,7 +267,6 @@
button.status-bar-item.scripts-debugger-show-hide-button:active {
top: 1px;
- right: 15px;
}
.status-bar-item.scripts-debugger-show-hide-button > .glyph {
@@ -277,10 +275,26 @@
-webkit-mask-image: url(Images/navigatorShowHideButton.png);
}
+button.status-bar-item.scripts-debugger-show-hide-button.toggled-shown {
+ right: 16px;
+}
+
+button.status-bar-item.scripts-debugger-show-hide-button.toggled-shown:active {
+ right: 15px;
+}
+
.status-bar-item.scripts-debugger-show-hide-button.toggled-shown > .glyph {
-webkit-mask-position: 0 -16px;
}
+button.status-bar-item.scripts-debugger-show-hide-button.toggled-hidden {
+ right: 1px;
+}
+
+button.status-bar-item.scripts-debugger-show-hide-button.toggled-hidden:active {
+ right: 0px;
+}
+
.status-bar-item.scripts-debugger-show-hide-button.toggled-hidden > .glyph {
-webkit-mask-position: -16px -16px;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
