Title: [127128] trunk/Source/_javascript_Core
Revision
127128
Author
[email protected]
Date
2012-08-30 05:37:11 -0700 (Thu, 30 Aug 2012)

Log Message

[BlackBerry] Eliminate build warnings
https://bugs.webkit.org/show_bug.cgi?id=95338

Reviewed by Filip Pizlo.

static_cast to the same type to eliminate the build time warnings.

* assembler/AssemblerBufferWithConstantPool.h:
(JSC::AssemblerBufferWithConstantPool::flushWithoutBarrier):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branch32):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (127127 => 127128)


--- trunk/Source/_javascript_Core/ChangeLog	2012-08-30 11:53:09 UTC (rev 127127)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-08-30 12:37:11 UTC (rev 127128)
@@ -1,3 +1,17 @@
+2012-08-30  Charles Wei  <[email protected]>
+
+        [BlackBerry] Eliminate build warnings
+        https://bugs.webkit.org/show_bug.cgi?id=95338
+
+        Reviewed by Filip Pizlo.
+
+        static_cast to the same type to eliminate the build time warnings.
+
+        * assembler/AssemblerBufferWithConstantPool.h:
+        (JSC::AssemblerBufferWithConstantPool::flushWithoutBarrier):
+        * assembler/MacroAssemblerARM.h:
+        (JSC::MacroAssemblerARM::branch32):
+
 2012-08-29  Mark Hahnenberg  <[email protected]>
 
         Remove use of ClassInfo from compileGetByValOnArguments and compileGetArgumentsLength

Modified: trunk/Source/_javascript_Core/assembler/AssemblerBufferWithConstantPool.h (127127 => 127128)


--- trunk/Source/_javascript_Core/assembler/AssemblerBufferWithConstantPool.h	2012-08-30 11:53:09 UTC (rev 127127)
+++ trunk/Source/_javascript_Core/assembler/AssemblerBufferWithConstantPool.h	2012-08-30 12:37:11 UTC (rev 127128)
@@ -215,7 +215,7 @@
     void flushWithoutBarrier(bool isForced = false)
     {
         // Flush if constant pool is more than 60% full to avoid overuse of this function.
-        if (isForced || 5 * m_numConsts > 3 * maxPoolSize / sizeof(uint32_t))
+        if (isForced || 5 * static_cast<uint32_t>(m_numConsts) > 3 * maxPoolSize / sizeof(uint32_t))
             flushConstantPool(false);
     }
 

Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (127127 => 127128)


--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2012-08-30 11:53:09 UTC (rev 127127)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2012-08-30 12:37:11 UTC (rev 127128)
@@ -555,7 +555,7 @@
 
     Jump branch32(RelationalCondition cond, RegisterID left, TrustedImm32 right, int useConstantPool = 0)
     {
-        ARMWord tmp = (right.m_value == 0x80000000) ? ARMAssembler::InvalidImmediate : m_assembler.getOp2(-right.m_value);
+        ARMWord tmp = (static_cast<unsigned>(right.m_value) == 0x80000000) ? ARMAssembler::InvalidImmediate : m_assembler.getOp2(-right.m_value);
         if (tmp != ARMAssembler::InvalidImmediate)
             m_assembler.cmn(left, tmp);
         else
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to