Title: [127146] trunk/Source/WebKit/blackberry
- Revision
- 127146
- Author
- [email protected]
- Date
- 2012-08-30 08:53:23 -0700 (Thu, 30 Aug 2012)
Log Message
[BlackBerry] node search does not work with elements on touch start listener
https://bugs.webkit.org/show_bug.cgi?id=95252
Patch by Hanna Ma <[email protected]> on 2012-08-30
Reviewed by Antonio Gomes.
Fix the node search function of web insepctor on elements with touch start listener.
Add methods from webPage to check if the node search functionality is enabled before handling touch events.
PR194107
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::touchEvent):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (127145 => 127146)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-08-30 15:51:25 UTC (rev 127145)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-08-30 15:53:23 UTC (rev 127146)
@@ -75,6 +75,7 @@
#include "InspectorBackendDispatcher.h"
#include "InspectorClientBlackBerry.h"
#include "InspectorController.h"
+#include "InspectorInstrumentation.h"
#include "InspectorOverlay.h"
#include "_javascript_DebuggerBlackBerry.h"
#include "_javascript_Variant_p.h"
@@ -4096,6 +4097,10 @@
if (d->m_page->defersLoading())
return false;
+ // FIXME: this checks if node search on inspector is enabled, though it might not be optimized.
+ if (InspectorInstrumentation::handleMousePress(d->m_mainFrame->page()))
+ return false;
+
PluginView* pluginView = d->m_fullScreenPluginView.get();
if (pluginView)
return d->dispatchTouchEventToFullScreenPlugin(pluginView, event);
Modified: trunk/Source/WebKit/blackberry/ChangeLog (127145 => 127146)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-08-30 15:51:25 UTC (rev 127145)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-08-30 15:53:23 UTC (rev 127146)
@@ -1,3 +1,17 @@
+2012-08-30 Hanna Ma <[email protected]>
+
+ [BlackBerry] node search does not work with elements on touch start listener
+ https://bugs.webkit.org/show_bug.cgi?id=95252
+
+ Reviewed by Antonio Gomes.
+
+ Fix the node search function of web insepctor on elements with touch start listener.
+ Add methods from webPage to check if the node search functionality is enabled before handling touch events.
+ PR194107
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPage::touchEvent):
+
2012-08-30 Arvid Nilsson <[email protected]>
[BlackBerry] One shot drawing sync flag never cleared when there's no layers
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
