Title: [127160] trunk/Source/WebKit/blackberry
- Revision
- 127160
- Author
- [email protected]
- Date
- 2012-08-30 10:47:31 -0700 (Thu, 30 Aug 2012)
Log Message
[BlackBerry] Remove unneeded force-immediate-repaint from InRegionScroller::setLayerScrollPosition
https://bugs.webkit.org/show_bug.cgi?id=95476
PR #200704
Reviewed by Yong Li.
Patch by Antonio Gomes <[email protected]>
This code is not needed at this point for neither the fast nor slow in-region
scroll codepaths, and it a huge performance beast as it forces all
containers to get full-repainted per scroll call (in webkit thread).
Patch also take this opportunity to remove an early-return we
have in the {i}frame slow scrolling code path so that we can
adjust the selection handles in this case as well.
* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp (127159 => 127160)
--- trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp 2012-08-30 17:44:54 UTC (rev 127159)
+++ trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp 2012-08-30 17:47:31 UTC (rev 127160)
@@ -289,14 +289,12 @@
backingStoreClient->setIsScrollNotificationSuppressed(false);
}
- return true;
+ } else {
+
+ // RenderBox-based elements case (scrollable boxes (div's, p's, textarea's, etc)).
+ layer->scrollToOffset(toSize(scrollPosition));
}
- // RenderBox-based elements case (scrollable boxes (div's, p's, textarea's, etc)).
- layer->scrollToOffset(scrollPosition.x(), scrollPosition.y());
- // FIXME_agomes: Please recheck if it is needed still!
- layer->renderer()->repaint(true);
-
m_webPage->m_selectionHandler->selectionPositionChanged();
// FIXME: We have code in place to handle scrolling and clipping tap highlight
// on in-region scrolling. As soon as it is fast enough (i.e. we have it backed by
Modified: trunk/Source/WebKit/blackberry/ChangeLog (127159 => 127160)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-08-30 17:44:54 UTC (rev 127159)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-08-30 17:47:31 UTC (rev 127160)
@@ -1,3 +1,22 @@
+2012-08-30 Antonio Gomes <[email protected]>
+
+ [BlackBerry] Remove unneeded force-immediate-repaint from InRegionScroller::setLayerScrollPosition
+ https://bugs.webkit.org/show_bug.cgi?id=95476
+ PR #200704
+
+ Reviewed by Yong Li.
+
+ This code is not needed at this point for neither the fast nor slow in-region
+ scroll codepaths, and it is a huge performance beast as it forces all
+ containers to get full-repainted per scroll call (in webkit thread).
+
+ Patch also take this opportunity to remove an early-return we
+ have in the {i}frame slow scrolling code path so that we can
+ adjust the selection handles in this case as well.
+
+ * Api/InRegionScroller.cpp:
+ (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
+
2012-08-30 Hanna Ma <[email protected]>
[BlackBerry] node search does not work with elements on touch start listener
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
