Title: [127167] trunk/Source/_javascript_Core
- Revision
- 127167
- Author
- [email protected]
- Date
- 2012-08-30 11:45:03 -0700 (Thu, 30 Aug 2012)
Log Message
Build warning : -Wsign-compare on DFGByteCodeParser.cpp.
https://bugs.webkit.org/show_bug.cgi?id=95418
Patch by Byungwoo Lee <[email protected]> on 2012-08-30
Reviewed by Filip Pizlo.
There is a build warning '-Wsign-compare' on
findArgumentPositionForLocal() in DFGByteCodeParser.cpp.
For removing this warning, casting statement is added explicitly.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::findArgumentPosition):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (127166 => 127167)
--- trunk/Source/_javascript_Core/ChangeLog 2012-08-30 18:41:36 UTC (rev 127166)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-08-30 18:45:03 UTC (rev 127167)
@@ -1,3 +1,19 @@
+2012-08-30 Byungwoo Lee <[email protected]>
+
+ Build warning : -Wsign-compare on DFGByteCodeParser.cpp.
+ https://bugs.webkit.org/show_bug.cgi?id=95418
+
+ Reviewed by Filip Pizlo.
+
+ There is a build warning '-Wsign-compare' on
+ findArgumentPositionForLocal() in DFGByteCodeParser.cpp.
+
+ For removing this warning, casting statement is added explicitly.
+
+ * dfg/DFGByteCodeParser.cpp:
+ (JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
+ (JSC::DFG::ByteCodeParser::findArgumentPosition):
+
2012-08-30 Yong Li <[email protected]>
[BlackBerry] Set timer client on platform timer used in HeapTimer
Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (127166 => 127167)
--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2012-08-30 18:41:36 UTC (rev 127166)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2012-08-30 18:45:03 UTC (rev 127167)
@@ -365,11 +365,11 @@
InlineCallFrame* inlineCallFrame = stack->m_inlineCallFrame;
if (!inlineCallFrame)
break;
- if (operand >= inlineCallFrame->stackOffset - RegisterFile::CallFrameHeaderSize)
+ if (operand >= static_cast<int>(inlineCallFrame->stackOffset - RegisterFile::CallFrameHeaderSize))
continue;
if (operand == inlineCallFrame->stackOffset + CallFrame::thisArgumentOffset())
continue;
- if (static_cast<unsigned>(operand) < inlineCallFrame->stackOffset - RegisterFile::CallFrameHeaderSize - inlineCallFrame->arguments.size())
+ if (operand < static_cast<int>(inlineCallFrame->stackOffset - RegisterFile::CallFrameHeaderSize - inlineCallFrame->arguments.size()))
continue;
int argument = operandToArgument(operand - inlineCallFrame->stackOffset);
return stack->m_argumentPositions[argument];
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
