Title: [127176] trunk
- Revision
- 127176
- Author
- [email protected]
- Date
- 2012-08-30 13:06:22 -0700 (Thu, 30 Aug 2012)
Log Message
[Chromium] Layout Test media/track/track-cue-rendering-snap-to-lines-not-set.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=89167
Reviewed by Eric Carlson.
Source/WebCore:
Fix for rendering tracks when snap-to-lines not set.
No new tests. Removed from TestExpectations existing test.
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::calculateDisplayParameters): Updated the place
where m_computedLinePosition is determined.
LayoutTests:
Removed possible flaky test from TestExceptations.
* platform/chromium/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (127175 => 127176)
--- trunk/LayoutTests/ChangeLog 2012-08-30 20:02:02 UTC (rev 127175)
+++ trunk/LayoutTests/ChangeLog 2012-08-30 20:06:22 UTC (rev 127176)
@@ -1,3 +1,14 @@
+2012-08-30 Victor Carbune <[email protected]>
+
+ [Chromium] Layout Test media/track/track-cue-rendering-snap-to-lines-not-set.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=89167
+
+ Reviewed by Eric Carlson.
+
+ Removed possible flaky test from TestExceptations.
+
+ * platform/chromium/TestExpectations:
+
2012-08-30 Alexandru Chiculita <[email protected]>
[CSS Shaders] Update css3/filters/custom/effect-custom-transform-parameters.html to remove anti-aliasing issues
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (127175 => 127176)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-30 20:02:02 UTC (rev 127175)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-30 20:06:22 UTC (rev 127176)
@@ -3301,9 +3301,6 @@
BUGCR132898 : http/tests/websocket/tests/hybi/workers/close.html = PASS TEXT
-// Flaky
-BUGWK89167 : media/track/track-cue-rendering-snap-to-lines-not-set.html = TEXT PASS
-
// Timing out on some Windows bots
BUGWK89510 WIN : gamepad/gamepad-polling-access.html = PASS TIMEOUT
Modified: trunk/Source/WebCore/ChangeLog (127175 => 127176)
--- trunk/Source/WebCore/ChangeLog 2012-08-30 20:02:02 UTC (rev 127175)
+++ trunk/Source/WebCore/ChangeLog 2012-08-30 20:06:22 UTC (rev 127176)
@@ -1,3 +1,19 @@
+2012-08-30 Victor Carbune <[email protected]>
+
+ [Chromium] Layout Test media/track/track-cue-rendering-snap-to-lines-not-set.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=89167
+
+ Reviewed by Eric Carlson.
+
+ Fix for rendering tracks when snap-to-lines not set.
+
+ No new tests. Removed from TestExpectations existing test.
+
+ * html/track/TextTrackCue.cpp:
+ (WebCore::TextTrackCue::TextTrackCue):
+ (WebCore::TextTrackCue::calculateDisplayParameters): Updated the place
+ where m_computedLinePosition is determined.
+
2012-08-27 James Robinson <[email protected]>
[chromium] Add CompositorSupport interface for constructing compositor classes
Modified: trunk/Source/WebCore/html/track/TextTrackCue.cpp (127175 => 127176)
--- trunk/Source/WebCore/html/track/TextTrackCue.cpp 2012-08-30 20:02:02 UTC (rev 127175)
+++ trunk/Source/WebCore/html/track/TextTrackCue.cpp 2012-08-30 20:06:22 UTC (rev 127176)
@@ -212,10 +212,6 @@
m_displayWritingModeMap[Horizontal] = CSSValueHorizontalTb;
m_displayWritingModeMap[VerticalGrowingLeft] = CSSValueVerticalRl;
m_displayWritingModeMap[VerticalGrowingRight] = CSSValueVerticalLr;
-
- // A text track cue has a text track cue computed line position whose value
- // is defined in terms of the other aspects of the cue.
- m_computedLinePosition = calculateComputedLinePosition();
}
TextTrackCue::~TextTrackCue()
@@ -644,6 +640,10 @@
if (!m_snapToLines && (m_writingDirection == VerticalGrowingLeft || m_writingDirection == VerticalGrowingRight))
m_displayPosition.first = m_computedLinePosition;
+
+ // A text track cue has a text track cue computed line position whose value
+ // is defined in terms of the other aspects of the cue.
+ m_computedLinePosition = calculateComputedLinePosition();
}
void TextTrackCue::updateDisplayTree(float movieTime)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
