Title: [127211] trunk/Source/_javascript_Core
- Revision
- 127211
- Author
- [email protected]
- Date
- 2012-08-30 16:36:41 -0700 (Thu, 30 Aug 2012)
Log Message
Try to fix the Qt build: Remove the inline keyword at the declaration
site.
The Qt compiler seems to be confused, complaining about these functions
not being defined in a translation unit, even though no generated code
in the unit calls these functions. Maybe removing the keyword at the
declaration site will change its mind.
This shouldn't change the inlining decision at all: the definition is
still inline.
* interpreter/CallFrame.h:
(ExecState):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (127210 => 127211)
--- trunk/Source/_javascript_Core/ChangeLog 2012-08-30 23:33:05 UTC (rev 127210)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-08-30 23:36:41 UTC (rev 127211)
@@ -1,5 +1,21 @@
2012-08-30 Geoffrey Garen <[email protected]>
+ Try to fix the Qt build: Remove the inline keyword at the declaration
+ site.
+
+ The Qt compiler seems to be confused, complaining about these functions
+ not being defined in a translation unit, even though no generated code
+ in the unit calls these functions. Maybe removing the keyword at the
+ declaration site will change its mind.
+
+ This shouldn't change the inlining decision at all: the definition is
+ still inline.
+
+ * interpreter/CallFrame.h:
+ (ExecState):
+
+2012-08-30 Geoffrey Garen <[email protected]>
+
Undo Qt build fix guess, since it breaks other builds.
* runtime/JSArray.h:
Modified: trunk/Source/_javascript_Core/interpreter/CallFrame.h (127210 => 127211)
--- trunk/Source/_javascript_Core/interpreter/CallFrame.h 2012-08-30 23:33:05 UTC (rev 127210)
+++ trunk/Source/_javascript_Core/interpreter/CallFrame.h 2012-08-30 23:36:41 UTC (rev 127211)
@@ -53,13 +53,13 @@
// Global object in which the currently executing code was defined.
// Differs from dynamicGlobalObject() during function calls across web browser frames.
- inline JSGlobalObject* lexicalGlobalObject() const;
+ JSGlobalObject* lexicalGlobalObject() const;
// Differs from lexicalGlobalObject because this will have DOM window shell rather than
// the actual DOM window, which can't be "this" for security reasons.
- inline JSObject* globalThisValue() const;
+ JSObject* globalThisValue() const;
- inline JSGlobalData& globalData() const;
+ JSGlobalData& globalData() const;
// Convenience functions for access to global data.
// It takes a few memory references to get from a call frame to the global data
@@ -183,9 +183,9 @@
}
// Read a register from the codeframe (or constant from the CodeBlock).
- inline Register& r(int);
+ Register& r(int);
// Read a register for a non-constant
- inline Register& uncheckedR(int);
+ Register& uncheckedR(int);
// Access to arguments.
size_t argumentCount() const { return argumentCountIncludingThis() - 1; }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
