Title: [127222] trunk
Revision
127222
Author
[email protected]
Date
2012-08-30 18:15:12 -0700 (Thu, 30 Aug 2012)

Log Message

ASSERTION FAILURE in JSC::JSGlobalData::float32ArrayDescriptor when running fast/js/dfg-float64array.html
https://bugs.webkit.org/show_bug.cgi?id=95398

Reviewed by Mark Hahnenberg.

Source/_javascript_Core:

Trying to get the build failure to be a bit more informative.

* runtime/JSGlobalData.h:
(JSGlobalData):

LayoutTests:

Temporarily unskipping tests to figure out what is going.

* platform/mac-wk2/Skipped:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (127221 => 127222)


--- trunk/LayoutTests/ChangeLog	2012-08-31 01:14:53 UTC (rev 127221)
+++ trunk/LayoutTests/ChangeLog	2012-08-31 01:15:12 UTC (rev 127222)
@@ -1,3 +1,14 @@
+2012-08-30  Filip Pizlo  <[email protected]>
+
+        ASSERTION FAILURE in JSC::JSGlobalData::float32ArrayDescriptor when running fast/js/dfg-float64array.html
+        https://bugs.webkit.org/show_bug.cgi?id=95398
+
+        Reviewed by Mark Hahnenberg.
+
+        Temporarily unskipping tests to figure out what is going.
+
+        * platform/mac-wk2/Skipped:
+
 2012-08-30  Roger Fong  <[email protected]>
 
         Unreviewed Gardening. http/security/referrer tests fail. Unable to load resources over https.

Modified: trunk/LayoutTests/platform/mac-wk2/Skipped (127221 => 127222)


--- trunk/LayoutTests/platform/mac-wk2/Skipped	2012-08-31 01:14:53 UTC (rev 127221)
+++ trunk/LayoutTests/platform/mac-wk2/Skipped	2012-08-31 01:15:12 UTC (rev 127222)
@@ -375,16 +375,6 @@
 sputnik/Unicode/Unicode_218/S7.6_A2.4.html
 sputnik/Unicode/Unicode_218/S7.6_A5.2_T1.html
 
-# Asserts under JSC::DFG::SpeculativeJIT::typedArrayDescriptor
-# https://bugs.webkit.org/show_bug.cgi?id=95398
-fast/js/dfg-int32array.html
-fast/js/dfg-float32array.html
-fast/js/dfg-uint8clampedarray.html
-fast/js/dfg-poison-fuzz.html
-fast/js/dfg-float64array.html
-fast/js/dfg-int32array-overflow-values.html
-fast/js/dfg-inline-function-dot-caller.html
-
 ### END OF (3) Unclassified failures
 ########################################
 

Modified: trunk/Source/_javascript_Core/ChangeLog (127221 => 127222)


--- trunk/Source/_javascript_Core/ChangeLog	2012-08-31 01:14:53 UTC (rev 127221)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-08-31 01:15:12 UTC (rev 127222)
@@ -1,3 +1,15 @@
+2012-08-30  Filip Pizlo  <[email protected]>
+
+        ASSERTION FAILURE in JSC::JSGlobalData::float32ArrayDescriptor when running fast/js/dfg-float64array.html
+        https://bugs.webkit.org/show_bug.cgi?id=95398
+
+        Reviewed by Mark Hahnenberg.
+
+        Trying to get the build failure to be a bit more informative.
+
+        * runtime/JSGlobalData.h:
+        (JSGlobalData):
+
 2012-08-30  Geoffrey Garen  <[email protected]>
 
         Try to fix the Qt build: add some #includes that, for some reason, only the Qt linker requires.

Modified: trunk/Source/_javascript_Core/runtime/JSGlobalData.h (127221 => 127222)


--- trunk/Source/_javascript_Core/runtime/JSGlobalData.h	2012-08-31 01:14:53 UTC (rev 127221)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalData.h	2012-08-31 01:15:12 UTC (rev 127222)
@@ -420,6 +420,7 @@
         { \
             ASSERT(!m_##type##ArrayDescriptor.m_classInfo || m_##type##ArrayDescriptor.m_classInfo == descriptor.m_classInfo); \
             m_##type##ArrayDescriptor = descriptor; \
+            ASSERT(m_##type##ArrayDescriptor.m_classInfo); \
         } \
         const TypedArrayDescriptor& type##ArrayDescriptor() const { ASSERT(m_##type##ArrayDescriptor.m_classInfo); return m_##type##ArrayDescriptor; }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to