Title: [127253] trunk/Source/WebKit2
- Revision
- 127253
- Author
- [email protected]
- Date
- 2012-08-31 06:33:59 -0700 (Fri, 31 Aug 2012)
Log Message
[Qt] QNX does not support SOCK_SEQPACKET socket type for socketpair in ProcessLauncherQt
https://bugs.webkit.org/show_bug.cgi?id=95553
Patch by Milian Wolff <[email protected]> on 2012-08-31
Reviewed by Simon Hausmann.
Calling socketpair with SOCK_SEQPACKET socket type fails on QNX with an error 241 (EPROTOTYPE),
as can be seen by the following debug output: "Creation of socket failed with errno: 241".
A test app shows that SOCK_DGRAM works properly on QNX, thus use it instead of SOCK_SEQPACKET.
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (127252 => 127253)
--- trunk/Source/WebKit2/ChangeLog 2012-08-31 13:17:25 UTC (rev 127252)
+++ trunk/Source/WebKit2/ChangeLog 2012-08-31 13:33:59 UTC (rev 127253)
@@ -1,3 +1,16 @@
+2012-08-31 Milian Wolff <[email protected]>
+
+ [Qt] QNX does not support SOCK_SEQPACKET socket type for socketpair in ProcessLauncherQt
+ https://bugs.webkit.org/show_bug.cgi?id=95553
+
+ Reviewed by Simon Hausmann.
+
+ Calling socketpair with SOCK_SEQPACKET socket type fails on QNX with an error 241 (EPROTOTYPE),
+ as can be seen by the following debug output: "Creation of socket failed with errno: 241".
+ A test app shows that SOCK_DGRAM works properly on QNX, thus use it instead of SOCK_SEQPACKET.
+
+ * UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
+
2012-08-30 Mark Hahnenberg <[email protected]>
~JSNPObject should call invalidate() if it hasn't been called already
Modified: trunk/Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp (127252 => 127253)
--- trunk/Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp 2012-08-31 13:17:25 UTC (rev 127252)
+++ trunk/Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp 2012-08-31 13:33:59 UTC (rev 127253)
@@ -62,7 +62,8 @@
extern "C" kern_return_t bootstrap_register2(mach_port_t, name_t, mach_port_t, uint64_t);
#endif
-#if defined(SOCK_SEQPACKET) && !defined(Q_OS_MACX)
+// for QNX we need SOCK_DGRAM, see https://bugs.webkit.org/show_bug.cgi?id=95553
+#if defined(SOCK_SEQPACKET) && !defined(Q_OS_MACX) && !OS(QNX)
#define SOCKET_TYPE SOCK_SEQPACKET
#else
#define SOCKET_TYPE SOCK_DGRAM
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
