Title: [127268] trunk/Tools
- Revision
- 127268
- Author
- [email protected]
- Date
- 2012-08-31 08:49:00 -0700 (Fri, 31 Aug 2012)
Log Message
[Qt] ImageDiff output is not in the expected form if image dimensions differ
https://bugs.webkit.org/show_bug.cgi?id=95575
Reviewed by Csaba Osztrogonác.
Output 100% difference in the case of differing image dimensions so
the test harness knows that we won't produce any output further.
This matches the behavior of other ports.
* DumpRenderTree/qt/ImageDiff.cpp:
(main):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (127267 => 127268)
--- trunk/Tools/ChangeLog 2012-08-31 15:47:04 UTC (rev 127267)
+++ trunk/Tools/ChangeLog 2012-08-31 15:49:00 UTC (rev 127268)
@@ -1,3 +1,17 @@
+2012-08-31 Balazs Kelemen <[email protected]>
+
+ [Qt] ImageDiff output is not in the expected form if image dimensions differ
+ https://bugs.webkit.org/show_bug.cgi?id=95575
+
+ Reviewed by Csaba Osztrogonác.
+
+ Output 100% difference in the case of differing image dimensions so
+ the test harness knows that we won't produce any output further.
+ This matches the behavior of other ports.
+
+ * DumpRenderTree/qt/ImageDiff.cpp:
+ (main):
+
2012-08-31 Sheriff Bot <[email protected]>
Unreviewed, rolling out r127261.
Modified: trunk/Tools/DumpRenderTree/qt/ImageDiff.cpp (127267 => 127268)
--- trunk/Tools/DumpRenderTree/qt/ImageDiff.cpp 2012-08-31 15:47:04 UTC (rev 127267)
+++ trunk/Tools/DumpRenderTree/qt/ImageDiff.cpp 2012-08-31 15:49:00 UTC (rev 127268)
@@ -83,8 +83,10 @@
if (!actualImage.isNull() && !baselineImage.isNull()) {
if (actualImage.size() != baselineImage.size()) {
+ fprintf(stdout, "diff: 100%% failed\n");
fprintf(stderr, "error, test and reference image have different properties.\n");
fflush(stderr);
+ fflush(stdout);
} else {
int w = actualImage.width();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
