Title: [127362] trunk/LayoutTests
- Revision
- 127362
- Author
- [email protected]
- Date
- 2012-09-01 00:38:12 -0700 (Sat, 01 Sep 2012)
Log Message
[Tests] Move fast/notifications/notifications-event-listener-crash.html to http/tests/notifications
https://bugs.webkit.org/show_bug.cgi?id=95535
<rdar://problem/12213781>
Reviewed by Jessie Berlin.
This test is among a few that are being migrated from fast/notifications to http/tests/notifications because of permissions.
Since most notifications tests will involve permissions, it is easier to have all of them consolidated in the same directory.
This test has been slightly modified to take advantage of the new testRunner notifications API. The test itself also does not
need to be protected within the window.testRunner check since it does not use that object.
* fast/notifications/notifications-event-listener-crash-expected.txt: Removed.
* fast/notifications/notifications-event-listener-crash.html: Removed.
* http/tests/notifications/event-listener-crash-expected.txt: Added.
* http/tests/notifications/event-listener-crash.html: Added.
Modified Paths
Added Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (127361 => 127362)
--- trunk/LayoutTests/ChangeLog 2012-09-01 07:29:56 UTC (rev 127361)
+++ trunk/LayoutTests/ChangeLog 2012-09-01 07:38:12 UTC (rev 127362)
@@ -1,3 +1,22 @@
+2012-08-31 Jon Lee <[email protected]>
+
+ [Tests] Move fast/notifications/notifications-event-listener-crash.html to http/tests/notifications
+ https://bugs.webkit.org/show_bug.cgi?id=95535
+ <rdar://problem/12213781>
+
+ Reviewed by Jessie Berlin.
+
+ This test is among a few that are being migrated from fast/notifications to http/tests/notifications because of permissions.
+ Since most notifications tests will involve permissions, it is easier to have all of them consolidated in the same directory.
+
+ This test has been slightly modified to take advantage of the new testRunner notifications API. The test itself also does not
+ need to be protected within the window.testRunner check since it does not use that object.
+
+ * fast/notifications/notifications-event-listener-crash-expected.txt: Removed.
+ * fast/notifications/notifications-event-listener-crash.html: Removed.
+ * http/tests/notifications/event-listener-crash-expected.txt: Added.
+ * http/tests/notifications/event-listener-crash.html: Added.
+
2012-08-31 Kent Tamura <[email protected]>
[Chromium] Text expectation update
Deleted: trunk/LayoutTests/fast/notifications/notifications-event-listener-crash-expected.txt (127361 => 127362)
--- trunk/LayoutTests/fast/notifications/notifications-event-listener-crash-expected.txt 2012-09-01 07:29:56 UTC (rev 127361)
+++ trunk/LayoutTests/fast/notifications/notifications-event-listener-crash-expected.txt 2012-09-01 07:38:12 UTC (rev 127362)
@@ -1,5 +0,0 @@
-PASS successfullyParsed is true
-
-TEST COMPLETE
-PASS No crash.
-
Deleted: trunk/LayoutTests/fast/notifications/notifications-event-listener-crash.html (127361 => 127362)
--- trunk/LayoutTests/fast/notifications/notifications-event-listener-crash.html 2012-09-01 07:29:56 UTC (rev 127361)
+++ trunk/LayoutTests/fast/notifications/notifications-event-listener-crash.html 2012-09-01 07:38:12 UTC (rev 127362)
@@ -1,23 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<script src=""
-</head>
-<body>
-<p id="description"></p>
-<div id="console"></div>
-<script>
-if (window.testRunner) {
- testRunner.waitUntilDone();
- setTimeout(function() {
- testPassed('No crash.');
- testRunner.notifyDone();
- }, 0);
-}
-
-new Notification("title", { onclick: null });
-successfullyParsed = true;
-</script>
-<script src=""
-</body>
-</html>
\ No newline at end of file
Added: trunk/LayoutTests/http/tests/notifications/event-listener-crash-expected.txt (0 => 127362)
--- trunk/LayoutTests/http/tests/notifications/event-listener-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/notifications/event-listener-crash-expected.txt 2012-09-01 07:38:12 UTC (rev 127362)
@@ -0,0 +1,10 @@
+Test that setting a null event listener in the options dictionary does not cause a crash.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS No crash.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/http/tests/notifications/event-listener-crash.html (0 => 127362)
--- trunk/LayoutTests/http/tests/notifications/event-listener-crash.html (rev 0)
+++ trunk/LayoutTests/http/tests/notifications/event-listener-crash.html 2012-09-01 07:38:12 UTC (rev 127362)
@@ -0,0 +1,20 @@
+<!DOCTYPE html>
+<script src=""
+<script src=""
+<p id="description"></p>
+<div id="console"></div>
+<script>
+if (window.testRunner) {
+ testRunner.grantWebNotificationPermission(testURL);
+ testRunner.waitUntilDone();
+}
+
+description("Test that setting a null event listener in the options dictionary does not cause a crash.");
+
+new Notification("title", { onshow: null });
+
+setTimeout(function() {
+ testPassed('No crash.');
+ testCompleted();
+}, 0);
+</script>
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
