Title: [127432] trunk/Source/WebKit2
- Revision
- 127432
- Author
- [email protected]
- Date
- 2012-09-03 12:14:42 -0700 (Mon, 03 Sep 2012)
Log Message
[Qt] Not all activated elements highlighted, but some frames are
https://bugs.webkit.org/show_bug.cgi?id=95683
Reviewed by Kenneth Rohde Christiansen.
Use the new function Node::willRespondToMouseClickEvents to better determine if the element
can be tap-activated and avoid documents and frames completely.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::highlightPotentialActivation):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (127431 => 127432)
--- trunk/Source/WebKit2/ChangeLog 2012-09-03 18:38:54 UTC (rev 127431)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-03 19:14:42 UTC (rev 127432)
@@ -1,3 +1,16 @@
+2012-09-03 Allan Sandfeld Jensen <[email protected]>
+
+ [Qt] Not all activated elements highlighted, but some frames are
+ https://bugs.webkit.org/show_bug.cgi?id=95683
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Use the new function Node::willRespondToMouseClickEvents to better determine if the element
+ can be tap-activated and avoid documents and frames completely.
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::highlightPotentialActivation):
+
2012-09-03 Eunmi Lee <[email protected]>
[EFL][WK2] Add ewk_settings.
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (127431 => 127432)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-09-03 18:38:54 UTC (rev 127431)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-09-03 19:14:42 UTC (rev 127432)
@@ -1562,7 +1562,9 @@
// pages has a global click handler and we do not want to highlight the body.
// Instead find the enclosing link or focusable element, or the last enclosing inline element.
for (Node* node = adjustedNode; node; node = node->parentOrHostNode()) {
- if (node->isMouseFocusable() || node->isLink()) {
+ if (node->isDocumentNode() || node->isFrameOwnerElement())
+ break;
+ if (node->isMouseFocusable() || node->willRespondToMouseClickEvents()) {
activationNode = node;
break;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
