Title: [127437] trunk/Source/WebCore
- Revision
- 127437
- Author
- [email protected]
- Date
- 2012-09-03 19:09:42 -0700 (Mon, 03 Sep 2012)
Log Message
Web Inspector: the URL of worker inspector window sometimes is invalid
https://bugs.webkit.org/show_bug.cgi?id=95334
Patch by Peter Wang <[email protected]> on 2012-09-03
Reviewed by Pavel Feldman.
In "_openInspectorWindow", before "&dedicatedWorkerId=" should have a '?' to make the whole URL valid.
No new tests case for this bug.
* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.prototype._openInspectorWindow):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (127436 => 127437)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 01:44:41 UTC (rev 127436)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 02:09:42 UTC (rev 127437)
@@ -1,3 +1,17 @@
+2012-09-03 Peter Wang <[email protected]>
+
+ Web Inspector: the URL of worker inspector window sometimes is invalid
+ https://bugs.webkit.org/show_bug.cgi?id=95334
+
+ Reviewed by Pavel Feldman.
+
+ In "_openInspectorWindow", before "&dedicatedWorkerId=" should have a '?' to make the whole URL valid.
+
+ No new tests case for this bug.
+
+ * inspector/front-end/WorkerManager.js:
+ (WebInspector.WorkerManager.prototype._openInspectorWindow):
+
2012-09-03 Jinwoo Song <[email protected]>
[EFL] Fix e_dbus_shutdown() error when exiting the Minibrowser
Modified: trunk/Source/WebCore/inspector/front-end/WorkerManager.js (127436 => 127437)
--- trunk/Source/WebCore/inspector/front-end/WorkerManager.js 2012-09-04 01:44:41 UTC (rev 127436)
+++ trunk/Source/WebCore/inspector/front-end/WorkerManager.js 2012-09-04 02:09:42 UTC (rev 127437)
@@ -161,10 +161,16 @@
_openInspectorWindow: function(workerId, workerIsPaused)
{
- var url = "" + "&dedicatedWorkerId=" + workerId;
+ var search = window.location.search;
+ var hash = window.location.hash;
+ var url = ""
+ // Make sure hash is in rear
+ url = "" "");
+ url += (search ? "&dedicatedWorkerId=" : "?dedicatedWorkerId=") + workerId;
if (workerIsPaused)
url += "&workerPaused=true";
url = "" "");
+ url += hash;
// Set location=0 just to make sure the front-end will be opened in a separate window, not in new tab.
var workerInspectorWindow = window.open(url, undefined, "location=0");
this._workerIdToWindow[workerId] = workerInspectorWindow;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
