Title: [127471] trunk/Source/WebCore
Revision
127471
Author
[email protected]
Date
2012-09-04 09:50:47 -0700 (Tue, 04 Sep 2012)

Log Message

[chromium] OpenTypeVerticalData.cpp in both webcore_remaining and webcore_platform seems to break incremental linking on Windows Chromium
https://bugs.webkit.org/show_bug.cgi?id=95744

Patch by Koji Ishii <[email protected]> on 2012-09-04
Unreviewed build fix, verified by Scott Graham.

The addition of 'platform/graphics/opentype/*' to webcore_platform in WebCore.gyp was redundant
because '/opentype/' was already included to webcore_remaining.
It was not only redundant but also breaks incremental linking.

No new tests are required because no behavior changes.

Patch by Koji Ishii <[email protected]> on 2012-09-04

* WebCore.gyp/WebCore.gyp: Removed platform/graphics/opentype/* from webcore_platform.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (127470 => 127471)


--- trunk/Source/WebCore/ChangeLog	2012-09-04 15:47:25 UTC (rev 127470)
+++ trunk/Source/WebCore/ChangeLog	2012-09-04 16:50:47 UTC (rev 127471)
@@ -1,3 +1,19 @@
+2012-09-04  Koji Ishii  <[email protected]>
+
+        [chromium] OpenTypeVerticalData.cpp in both webcore_remaining and webcore_platform seems to break incremental linking on Windows Chromium
+        https://bugs.webkit.org/show_bug.cgi?id=95744
+
+        Patch by Koji Ishii <[email protected]> on 2012-09-04
+        Unreviewed build fix, verified by Scott Graham.
+
+        The addition of 'platform/graphics/opentype/*' to webcore_platform in WebCore.gyp was redundant
+        because '/opentype/' was already included to webcore_remaining.
+        It was not only redundant but also breaks incremental linking.
+
+        No new tests are required because no behavior changes.
+
+        * WebCore.gyp/WebCore.gyp: Removed platform/graphics/opentype/* from webcore_platform.
+
 2012-09-04  Otto Derek Cheung  <[email protected]>
 
         [BlackBerry] Browser is not sending secured Cookie back to server over HTTPS connection

Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (127470 => 127471)


--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-09-04 15:47:25 UTC (rev 127470)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-09-04 16:50:47 UTC (rev 127471)
@@ -1843,10 +1843,6 @@
           'sources/': [
             ['exclude', 'Posix\\.cpp$'],
 
-            ['include', 'platform/graphics/opentype/OpenTypeTypes\\.h$'],
-            ['include', 'platform/graphics/opentype/OpenTypeVerticalData\\.cpp$'],
-            ['include', 'platform/graphics/opentype/OpenTypeVerticalData\\.h$'],
-
             # The Chromium Win currently uses GlyphPageTreeNodeChromiumWin.cpp from
             # platform/graphics/chromium, included by regex above, instead.
             ['exclude', 'platform/graphics/skia/FontCacheSkia\\.cpp$'],
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to