Title: [127483] trunk/Source
- Revision
- 127483
- Author
- [email protected]
- Date
- 2012-09-04 12:23:41 -0700 (Tue, 04 Sep 2012)
Log Message
[GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject()
https://bugs.webkit.org/show_bug.cgi?id=95740
Patch by Joanmarie Diggs <[email protected]> on 2012-09-04
Reviewed by Martin Robinson.
Source/WebCore:
Added sanity check to be sure we have a render object prior to seeing if
said object is an anonymous block.
Testing via unit test because a non-flaky layout test crasher could not
be found.
* accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Sanity check for render object added.
Source/WebKit/gtk:
Updated unit test.
* tests/testatk.c:
(testWebkitAtkComboBox): Added checks that the menu popup in a combo box
has 0 links and, more importantly, that checking doesn't result in a crash.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (127482 => 127483)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 19:11:43 UTC (rev 127482)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 19:23:41 UTC (rev 127483)
@@ -1,3 +1,20 @@
+2012-09-04 Joanmarie Diggs <[email protected]>
+
+ [GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject()
+ https://bugs.webkit.org/show_bug.cgi?id=95740
+
+ Reviewed by Martin Robinson.
+
+ Added sanity check to be sure we have a render object prior to seeing if
+ said object is an anonymous block.
+
+ Testing via unit test because a non-flaky layout test crasher could not
+ be found.
+
+ * accessibility/gtk/AccessibilityObjectAtk.cpp:
+ (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
+ Sanity check for render object added.
+
2012-09-04 Christophe Dumez <[email protected]>
Automatic features should work in sandboxed iframes if "allow-scripts" flag is set
Modified: trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp (127482 => 127483)
--- trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp 2012-09-04 19:11:43 UTC (rev 127482)
+++ trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp 2012-09-04 19:23:41 UTC (rev 127483)
@@ -104,7 +104,7 @@
// anonymous blocks which are aria-related to themselves have an aria role, nor
// have we encountered instances where the parent of an anonymous block also lacked
// an aria role but the grandparent had one.
- if (renderer()->isAnonymousBlock() && !parent->renderer()->isBody()
+ if (renderer() && renderer()->isAnonymousBlock() && !parent->renderer()->isBody()
&& parent->ariaRoleAttribute() == UnknownRole)
return IgnoreObject;
Modified: trunk/Source/WebKit/gtk/ChangeLog (127482 => 127483)
--- trunk/Source/WebKit/gtk/ChangeLog 2012-09-04 19:11:43 UTC (rev 127482)
+++ trunk/Source/WebKit/gtk/ChangeLog 2012-09-04 19:23:41 UTC (rev 127483)
@@ -1,3 +1,16 @@
+2012-09-04 Joanmarie Diggs <[email protected]>
+
+ [GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject()
+ https://bugs.webkit.org/show_bug.cgi?id=95740
+
+ Reviewed by Martin Robinson.
+
+ Updated unit test.
+
+ * tests/testatk.c:
+ (testWebkitAtkComboBox): Added checks that the menu popup in a combo box
+ has 0 links and, more importantly, that checking doesn't result in a crash.
+
2012-09-01 Joanmarie Diggs <[email protected]>
[Gtk] Incorrect/unexpected characters in the text of certain accessibles
Modified: trunk/Source/WebKit/gtk/tests/testatk.c (127482 => 127483)
--- trunk/Source/WebKit/gtk/tests/testatk.c 2012-09-04 19:11:43 UTC (rev 127482)
+++ trunk/Source/WebKit/gtk/tests/testatk.c 2012-09-04 19:23:41 UTC (rev 127483)
@@ -562,6 +562,10 @@
g_assert(selectedItem == item1);
g_object_unref(selectedItem);
+ /* Check that the menu popup has 0 links and doesn't crash from checking. */
+ gint nLinks = atk_hypertext_get_n_links(ATK_HYPERTEXT(menuPopup));
+ g_assert_cmpint(nLinks, ==, 0);
+
/* Check the implementations of the AtkAction interface. */
g_assert(ATK_IS_ACTION(comboBox));
AtkAction* atkAction = ATK_ACTION(comboBox);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
