Title: [127489] trunk/Source/WebKit/blackberry
- Revision
- 127489
- Author
- [email protected]
- Date
- 2012-09-04 13:03:17 -0700 (Tue, 04 Sep 2012)
Log Message
[BlackBerry] pass isMainFrame() through to notifyDocumentOnLoad()
https://bugs.webkit.org/show_bug.cgi?id=95766
Reviewed by Rob Buis.
Passing the frame status through will allow the client to make better
decisions about how to act on the onload.
* Api/WebPageClient.h:
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPageClient.h (127488 => 127489)
--- trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2012-09-04 19:59:35 UTC (rev 127488)
+++ trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2012-09-04 20:03:17 UTC (rev 127489)
@@ -104,7 +104,7 @@
virtual void notifyInRegionScrollingStartingPointChanged(const std::vector<Platform::ScrollViewBase*>&) = 0;
virtual void notifyNoMouseMoveOrTouchMoveHandlers() = 0;
- virtual void notifyDocumentOnLoad() = 0;
+ virtual void notifyDocumentOnLoad(bool) = 0;
virtual void notifyWindowObjectCleared() = 0;
virtual WebString invokeClientJavaScriptCallback(const char* const* args, unsigned numArgs) = 0;
Modified: trunk/Source/WebKit/blackberry/ChangeLog (127488 => 127489)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-04 19:59:35 UTC (rev 127488)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-04 20:03:17 UTC (rev 127489)
@@ -1,3 +1,17 @@
+2012-09-04 George Staikos <[email protected]>
+
+ [BlackBerry] pass isMainFrame() through to notifyDocumentOnLoad()
+ https://bugs.webkit.org/show_bug.cgi?id=95766
+
+ Reviewed by Rob Buis.
+
+ Passing the frame status through will allow the client to make better
+ decisions about how to act on the onload.
+
+ * Api/WebPageClient.h:
+ * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+ (WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):
+
2012-09-04 Rob Buis <[email protected]>
[BlackBerry] Provide virtual dtor for DumpRenderTreeClient
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp (127488 => 127489)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2012-09-04 19:59:35 UTC (rev 127488)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2012-09-04 20:03:17 UTC (rev 127489)
@@ -572,7 +572,7 @@
void FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents()
{
- m_webPagePrivate->m_client->notifyDocumentOnLoad();
+ m_webPagePrivate->m_client->notifyDocumentOnLoad(isMainFrame());
if (m_webPagePrivate->m_dumpRenderTree)
m_webPagePrivate->m_dumpRenderTree->didHandleOnloadEventsForFrame(m_frame);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes