Title: [127791] trunk/Source
- Revision
- 127791
- Author
- [email protected]
- Date
- 2012-09-06 16:14:08 -0700 (Thu, 06 Sep 2012)
Log Message
IndexedDB: make IDBKeyPath's string and array constructors explicit
https://bugs.webkit.org/show_bug.cgi?id=96004
Patch by Alec Flett <[email protected]> on 2012-09-06
Reviewed by Tony Chang.
Source/WebCore:
Making these explicit to avoid accidental implicit conversions.
No new tests, existing tests cover correctness.
* Modules/indexeddb/IDBKeyPath.h:
(IDBKeyPath):
Source/WebKit/chromium:
Fix test to use explicit constructor for IDBKeyPath.
* tests/IDBDatabaseBackendTest.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (127790 => 127791)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 22:48:43 UTC (rev 127790)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 23:14:08 UTC (rev 127791)
@@ -1,3 +1,17 @@
+2012-09-06 Alec Flett <[email protected]>
+
+ IndexedDB: make IDBKeyPath's string and array constructors explicit
+ https://bugs.webkit.org/show_bug.cgi?id=96004
+
+ Reviewed by Tony Chang.
+
+ Making these explicit to avoid accidental implicit conversions.
+
+ No new tests, existing tests cover correctness.
+
+ * Modules/indexeddb/IDBKeyPath.h:
+ (IDBKeyPath):
+
2012-09-06 Jeff Timanus <[email protected]>
[Chromium] Remove contentsScale and related logic from GraphicsLayerChromium.
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.h (127790 => 127791)
--- trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.h 2012-09-06 22:48:43 UTC (rev 127790)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.h 2012-09-06 23:14:08 UTC (rev 127791)
@@ -45,8 +45,8 @@
class IDBKeyPath {
public:
IDBKeyPath() : m_type(NullType) { }
- IDBKeyPath(const String&);
- IDBKeyPath(const Vector<String>& array);
+ explicit IDBKeyPath(const String&);
+ explicit IDBKeyPath(const Vector<String>& array);
enum Type {
NullType = 0,
Modified: trunk/Source/WebKit/chromium/ChangeLog (127790 => 127791)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 22:48:43 UTC (rev 127790)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 23:14:08 UTC (rev 127791)
@@ -1,3 +1,14 @@
+2012-09-06 Alec Flett <[email protected]>
+
+ IndexedDB: make IDBKeyPath's string and array constructors explicit
+ https://bugs.webkit.org/show_bug.cgi?id=96004
+
+ Reviewed by Tony Chang.
+
+ Fix test to use explicit constructor for IDBKeyPath.
+
+ * tests/IDBDatabaseBackendTest.cpp:
+
2012-09-06 Adrienne Walker <[email protected]>
[chromium] Remove GraphicsContext references from ContentLayerChromiumTest
Modified: trunk/Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp (127790 => 127791)
--- trunk/Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp 2012-09-06 22:48:43 UTC (rev 127790)
+++ trunk/Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp 2012-09-06 23:14:08 UTC (rev 127791)
@@ -57,12 +57,12 @@
EXPECT_GT(backingStore->refCount(), 1);
const bool autoIncrement = false;
- RefPtr<IDBObjectStoreBackendImpl> store = IDBObjectStoreBackendImpl::create(db.get(), "store", String("keyPath"), autoIncrement);
+ RefPtr<IDBObjectStoreBackendImpl> store = IDBObjectStoreBackendImpl::create(db.get(), "store", IDBKeyPath("keyPath"), autoIncrement);
EXPECT_GT(backingStore->refCount(), 1);
const bool unique = false;
const bool multiEntry = false;
- RefPtr<IDBIndexBackendImpl> index = IDBIndexBackendImpl::create(db.get(), store.get(), "index", String("keyPath"), unique, multiEntry);
+ RefPtr<IDBIndexBackendImpl> index = IDBIndexBackendImpl::create(db.get(), store.get(), "index", IDBKeyPath("keyPath"), unique, multiEntry);
EXPECT_GT(backingStore->refCount(), 1);
db.clear();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
