Title: [127802] trunk/Source
Revision
127802
Author
[email protected]
Date
2012-09-06 16:54:49 -0700 (Thu, 06 Sep 2012)

Log Message

[Qt] Deprecate String += operator
https://bugs.webkit.org/show_bug.cgi?id=95895

Patch by Lauro Neto <[email protected]> on 2012-09-06
Reviewed by Benjamin Poulain.

Source/WebCore:

Replaced String +=() with append.

* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::extraMediaControlsStyleSheet):

Source/WTF:

Remove Qt from WTF_DEPRECATED_STRING_OPERATORS guard.

* wtf/Platform.h:

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (127801 => 127802)


--- trunk/Source/WTF/ChangeLog	2012-09-06 23:52:46 UTC (rev 127801)
+++ trunk/Source/WTF/ChangeLog	2012-09-06 23:54:49 UTC (rev 127802)
@@ -1,3 +1,14 @@
+2012-09-06  Lauro Neto  <[email protected]>
+
+        [Qt] Deprecate String += operator
+        https://bugs.webkit.org/show_bug.cgi?id=95895
+
+        Reviewed by Benjamin Poulain.
+
+        Remove Qt from WTF_DEPRECATED_STRING_OPERATORS guard.
+
+        * wtf/Platform.h:
+
 2012-09-06  Michael Saboff  <[email protected]>
 
         ENH: Add Logging to StringImpl to track String Types

Modified: trunk/Source/WTF/wtf/Platform.h (127801 => 127802)


--- trunk/Source/WTF/wtf/Platform.h	2012-09-06 23:52:46 UTC (rev 127801)
+++ trunk/Source/WTF/wtf/Platform.h	2012-09-06 23:54:49 UTC (rev 127802)
@@ -1185,7 +1185,7 @@
 #define WTF_USE_ZLIB 1
 #endif
 
-#if PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(WIN)
+#if PLATFORM(GTK) || PLATFORM(WIN)
 #define WTF_DEPRECATED_STRING_OPERATORS
 #endif
 

Modified: trunk/Source/WebCore/ChangeLog (127801 => 127802)


--- trunk/Source/WebCore/ChangeLog	2012-09-06 23:52:46 UTC (rev 127801)
+++ trunk/Source/WebCore/ChangeLog	2012-09-06 23:54:49 UTC (rev 127802)
@@ -1,3 +1,15 @@
+2012-09-06  Lauro Neto  <[email protected]>
+
+        [Qt] Deprecate String += operator
+        https://bugs.webkit.org/show_bug.cgi?id=95895
+
+        Reviewed by Benjamin Poulain.
+
+        Replaced String +=() with append.
+
+        * platform/qt/RenderThemeQt.cpp:
+        (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
+
 2012-09-06  Michael Saboff  <[email protected]>
 
         Add 8 bit string data path to TextRun

Modified: trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp (127801 => 127802)


--- trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp	2012-09-06 23:52:46 UTC (rev 127801)
+++ trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp	2012-09-06 23:54:49 UTC (rev 127802)
@@ -539,7 +539,7 @@
     String result = String(mediaControlsQtUserAgentStyleSheet, sizeof(mediaControlsQtUserAgentStyleSheet));
 
     if (m_page && m_page->chrome()->requiresFullscreenForVideoPlayback())
-        result += String(mediaControlsQtFullscreenUserAgentStyleSheet, sizeof(mediaControlsQtFullscreenUserAgentStyleSheet));
+        result.append(String(mediaControlsQtFullscreenUserAgentStyleSheet, sizeof(mediaControlsQtFullscreenUserAgentStyleSheet)));
 
     return result;
 }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to