Title: [127825] trunk
- Revision
- 127825
- Author
- [email protected]
- Date
- 2012-09-06 22:09:04 -0700 (Thu, 06 Sep 2012)
Log Message
[Gtk] accessibility/canvas-description-and-role expected results needed
https://bugs.webkit.org/show_bug.cgi?id=95644
Patch by Joanmarie Diggs <[email protected]> on 2012-09-06
Reviewed by Martin Robinson.
Source/WebCore:
The new accessibility CanvasRole should be mapped to ATK_ROLE_CANVAS
rather than ATK_ROLE_IMAGE.
No new test because the CanvasRole came with a new layout test lacking
expected results for Gtk. The generated expected results for that test
reflect the revised mapping to ATK_ROLE_CANVAS.
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
LayoutTests:
Generated expected results for Gtk. These results reflect the revised
mapping of CanvasRole to ATK_ROLE_CANVAS rather than ATK_ROLE_IMAGE.
* platform/gtk/accessibility/canvas-description-and-role-expected.txt: Added.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (127824 => 127825)
--- trunk/LayoutTests/ChangeLog 2012-09-07 05:03:29 UTC (rev 127824)
+++ trunk/LayoutTests/ChangeLog 2012-09-07 05:09:04 UTC (rev 127825)
@@ -1,3 +1,15 @@
+2012-09-06 Joanmarie Diggs <[email protected]>
+
+ [Gtk] accessibility/canvas-description-and-role expected results needed
+ https://bugs.webkit.org/show_bug.cgi?id=95644
+
+ Reviewed by Martin Robinson.
+
+ Generated expected results for Gtk. These results reflect the revised
+ mapping of CanvasRole to ATK_ROLE_CANVAS rather than ATK_ROLE_IMAGE.
+
+ * platform/gtk/accessibility/canvas-description-and-role-expected.txt: Added.
+
2012-09-06 Sheriff Bot <[email protected]>
Unreviewed, rolling out r127808.
Modified: trunk/LayoutTests/platform/gtk/accessibility/canvas-description-and-role-expected.txt (127824 => 127825)
--- trunk/LayoutTests/platform/gtk/accessibility/canvas-description-and-role-expected.txt 2012-09-07 05:03:29 UTC (rev 127824)
+++ trunk/LayoutTests/platform/gtk/accessibility/canvas-description-and-role-expected.txt 2012-09-07 05:09:04 UTC (rev 127825)
@@ -5,9 +5,9 @@
PASS axContainer.childrenCount is 2
Canvas 1 description: AXDescription: Canvas label
-Canvas 1 role: AXRole: AXCanvas
+Canvas 1 role: AXRole: canvas
Canvas 2 description: AXDescription:
-Canvas 2 role: AXRole: AXCanvas
+Canvas 2 role: AXRole: canvas
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/Source/WebCore/ChangeLog (127824 => 127825)
--- trunk/Source/WebCore/ChangeLog 2012-09-07 05:03:29 UTC (rev 127824)
+++ trunk/Source/WebCore/ChangeLog 2012-09-07 05:09:04 UTC (rev 127825)
@@ -1,3 +1,20 @@
+2012-09-06 Joanmarie Diggs <[email protected]>
+
+ [Gtk] accessibility/canvas-description-and-role expected results needed
+ https://bugs.webkit.org/show_bug.cgi?id=95644
+
+ Reviewed by Martin Robinson.
+
+ The new accessibility CanvasRole should be mapped to ATK_ROLE_CANVAS
+ rather than ATK_ROLE_IMAGE.
+
+ No new test because the CanvasRole came with a new layout test lacking
+ expected results for Gtk. The generated expected results for that test
+ reflect the revised mapping to ATK_ROLE_CANVAS.
+
+ * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
+ (atkRole):
+
2012-09-06 Hironori Bono <[email protected]>
A build fix for Chromium Windows
Modified: trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp (127824 => 127825)
--- trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp 2012-09-07 05:03:29 UTC (rev 127824)
+++ trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp 2012-09-07 05:09:04 UTC (rev 127825)
@@ -501,7 +501,6 @@
case WebCoreLinkRole:
case ImageMapLinkRole:
return ATK_ROLE_LINK;
- case CanvasRole:
case ImageMapRole:
case ImageRole:
return ATK_ROLE_IMAGE;
@@ -525,6 +524,8 @@
return ATK_ROLE_SECTION;
case FormRole:
return ATK_ROLE_FORM;
+ case CanvasRole:
+ return ATK_ROLE_CANVAS;
default:
return ATK_ROLE_UNKNOWN;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
