Title: [127870] trunk/Source/WebKit/blackberry
- Revision
- 127870
- Author
- [email protected]
- Date
- 2012-09-07 08:53:14 -0700 (Fri, 07 Sep 2012)
Log Message
[BlackBerry] Rendering issue after rotation
https://bugs.webkit.org/show_bug.cgi?id=96094
PR #201930
Patch by Robin Cao <[email protected]> on 2012-09-07
Reviewed by George Staikos.
The cause of the rendering issue is that the BackingStore tiles
are not reset after layout. This is a regression of r125680, which
overwrites a local variable that are used later in the function.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (127869 => 127870)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-09-07 15:36:43 UTC (rev 127869)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-09-07 15:53:14 UTC (rev 127870)
@@ -3811,16 +3811,17 @@
// We might need to layout here to get a correct contentsSize so that zoomToFit
// is calculated correctly.
- while (needsLayout) {
+ bool stillNeedsLayout = needsLayout;
+ while (stillNeedsLayout) {
setNeedsLayout();
requestLayoutIfNeeded();
- needsLayout = false;
+ stillNeedsLayout = false;
// Emulate the zoomToFitWidthOnLoad algorithm if we're rotating.
++m_nestedLayoutFinishedCount;
if (needsLayoutToFindContentSize) {
if (setViewMode(viewMode()))
- needsLayout = true;
+ stillNeedsLayout = true;
}
}
m_nestedLayoutFinishedCount = 0;
Modified: trunk/Source/WebKit/blackberry/ChangeLog (127869 => 127870)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-07 15:36:43 UTC (rev 127869)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-07 15:53:14 UTC (rev 127870)
@@ -1,3 +1,18 @@
+2012-09-07 Robin Cao <[email protected]>
+
+ [BlackBerry] Rendering issue after rotation
+ https://bugs.webkit.org/show_bug.cgi?id=96094
+ PR #201930
+
+ Reviewed by George Staikos.
+
+ The cause of the rendering issue is that the BackingStore tiles
+ are not reset after layout. This is a regression of r125680, which
+ overwrites a local variable that are used later in the function.
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
+
2012-09-06 Crystal Zhang <[email protected]>
[BlackBerry] Implement a color picker
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
