Title: [127975] trunk/Source/WebKit/blackberry
- Revision
- 127975
- Author
- [email protected]
- Date
- 2012-09-08 21:29:19 -0700 (Sat, 08 Sep 2012)
Log Message
[BlackBerry] Exiting fullscreen mode can leave user stuck without Browser menus
https://bugs.webkit.org/show_bug.cgi?id=96027
Patch by Max Feil <[email protected]> on 2012-09-08
Reviewed by Antonio Gomes.
The changes for bug 87337 (landed as trunk svn revision 119119)
introduced a bug. The same conditions are not checked on enter
fullscreen vs. exit. Web sites such as http://videojs.com
and youtube's mobile HTML5 player make the div container
of the video element go fullscreen. This is allowed in
WebPagePrivate::enterFullScreenForElement() but disallowed in
WebPagePrivate::exitFullScreenForElement(). I am fixing this by
allowing containers of video elements to exit fullscreen.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (127974 => 127975)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-09-09 00:35:47 UTC (rev 127974)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-09-09 04:29:19 UTC (rev 127975)
@@ -6025,7 +6025,7 @@
{
#if ENABLE(VIDEO)
// TODO: We should not check video tag when we decide to support all elements.
- if (!element || !element->hasTagName(HTMLNames::videoTag))
+ if (!element || (!element->hasTagName(HTMLNames::videoTag) && !containsVideoTags(element)))
return;
if (m_webSettings->fullScreenVideoCapable()) {
// The Browser chrome has its own fullscreen video widget.
Modified: trunk/Source/WebKit/blackberry/ChangeLog (127974 => 127975)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-09 00:35:47 UTC (rev 127974)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-09 04:29:19 UTC (rev 127975)
@@ -1,3 +1,22 @@
+2012-09-08 Max Feil <[email protected]>
+
+ [BlackBerry] Exiting fullscreen mode can leave user stuck without Browser menus
+ https://bugs.webkit.org/show_bug.cgi?id=96027
+
+ Reviewed by Antonio Gomes.
+
+ The changes for bug 87337 (landed as trunk svn revision 119119)
+ introduced a bug. The same conditions are not checked on enter
+ fullscreen vs. exit. Web sites such as http://videojs.com
+ and youtube's mobile HTML5 player make the div container
+ of the video element go fullscreen. This is allowed in
+ WebPagePrivate::enterFullScreenForElement() but disallowed in
+ WebPagePrivate::exitFullScreenForElement(). I am fixing this by
+ allowing containers of video elements to exit fullscreen.
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
+
2012-09-07 Ming Xie <[email protected]>
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
