Title: [127979] trunk/Source/WebCore
- Revision
- 127979
- Author
- [email protected]
- Date
- 2012-09-09 00:47:50 -0700 (Sun, 09 Sep 2012)
Log Message
[V8] convertEventTargetToV8Object doesn't need to be overloaded
https://bugs.webkit.org/show_bug.cgi?id=96195
Reviewed by Kentaro Hara.
WTF::getPtr solves this problem for us.
* bindings/scripts/CodeGeneratorV8.pm:
(NativeToJSValue):
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (127978 => 127979)
--- trunk/Source/WebCore/ChangeLog 2012-09-09 07:39:13 UTC (rev 127978)
+++ trunk/Source/WebCore/ChangeLog 2012-09-09 07:47:50 UTC (rev 127979)
@@ -1,5 +1,19 @@
2012-09-09 Adam Barth <[email protected]>
+ [V8] convertEventTargetToV8Object doesn't need to be overloaded
+ https://bugs.webkit.org/show_bug.cgi?id=96195
+
+ Reviewed by Kentaro Hara.
+
+ WTF::getPtr solves this problem for us.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (NativeToJSValue):
+ * bindings/v8/V8DOMWrapper.h:
+ (V8DOMWrapper):
+
+2012-09-09 Adam Barth <[email protected]>
+
[V8] V8PerContextData holds m_context using a v8::Handle rather than a v8::Persistent
https://bugs.webkit.org/show_bug.cgi?id=96193
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (127978 => 127979)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-09-09 07:39:13 UTC (rev 127978)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-09-09 07:47:50 UTC (rev 127979)
@@ -4062,7 +4062,7 @@
}
if ($type eq "EventTarget") {
- return "V8DOMWrapper::convertEventTargetToV8Object($value$getCreationContextArg$getIsolateArg)";
+ return "V8DOMWrapper::convertEventTargetToV8Object(WTF::getPtr($value)$getCreationContextArg$getIsolateArg)";
}
if ($type eq "EventListener") {
Modified: trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h (127978 => 127979)
--- trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h 2012-09-09 07:39:13 UTC (rev 127978)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h 2012-09-09 07:47:50 UTC (rev 127979)
@@ -81,11 +81,6 @@
static WrapperTypeInfo* domWrapperType(v8::Handle<v8::Object>);
- static v8::Handle<v8::Value> convertEventTargetToV8Object(PassRefPtr<EventTarget> eventTarget, v8::Handle<v8::Object> creationContext = v8::Handle<v8::Object>(), v8::Isolate* isolate = 0)
- {
- return convertEventTargetToV8Object(eventTarget.get(), creationContext, isolate);
- }
-
static v8::Handle<v8::Value> convertEventTargetToV8Object(EventTarget*, v8::Handle<v8::Object> creationContext = v8::Handle<v8::Object>(), v8::Isolate* = 0);
static PassRefPtr<EventListener> getEventListener(v8::Local<v8::Value> value, bool isAttribute, ListenerLookupType lookup);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
