Diff
Modified: trunk/LayoutTests/ChangeLog (128029 => 128030)
--- trunk/LayoutTests/ChangeLog 2012-09-10 08:09:56 UTC (rev 128029)
+++ trunk/LayoutTests/ChangeLog 2012-09-10 08:16:32 UTC (rev 128030)
@@ -1,5 +1,77 @@
2012-09-10 Christophe Dumez <[email protected]>
+ [WK2] New fast/forms/number/number-interactive-validation-required.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=95936
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Unskip fast/forms/number/number-interactive-validation-required.html for
+ several WebKit2 ports now that the interactive form validation setting is
+ enabled in WebKitTestRunner.
+
+ * platform/efl-wk2/TestExpectations:
+ * platform/qt-5.0-wk2/Skipped:
+
+2012-09-10 Csaba Osztrogonác <[email protected]>
+
+ [Qt][WK2] REGRESSION(r127861): It made one test fail and one test crash
+ https://bugs.webkit.org/show_bug.cgi?id=96243
+
+ Unreviewed gardening, skip new failing and crashing tests to paint the bot green.
+
+ * platform/qt-5.0-wk2/Skipped:
+
+2012-09-10 Christophe Dumez <[email protected]>
+
+ [EFL] Several fast/block test cases need rebaseline after r127163
+ https://bugs.webkit.org/show_bug.cgi?id=96237
+
+ Unreviewed EFL gardening.
+
+ Rebaseline 4 fast/block test cases due to r127163.
+
+ * platform/efl/TestExpectations:
+ * platform/efl/fast/block/float/024-expected.png:
+ * platform/efl/fast/block/float/024-expected.txt:
+ * platform/efl/fast/block/margin-collapse/025-expected.txt:
+ * platform/efl/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
+ * platform/efl/fast/block/margin-collapse/empty-clear-blocks-expected.png:
+ * platform/efl/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
+
+2012-09-10 Christophe Dumez <[email protected]>
+
+ [EFL] Add baseline for css3/masking test cases
+ https://bugs.webkit.org/show_bug.cgi?id=96235
+
+ Unreviewed EFL gardening.
+
+ Generate baselines for css3/masking test cases added
+ in r127608.
+
+ * platform/efl/TestExpectations:
+ * platform/efl/css3/masking/clip-path-circle-expected.png: Added.
+ * platform/efl/css3/masking/clip-path-circle-expected.txt: Added.
+ * platform/efl/css3/masking/clip-path-circle-filter-expected.png: Added.
+ * platform/efl/css3/masking/clip-path-circle-filter-expected.txt: Added.
+ * platform/efl/css3/masking/clip-path-circle-overflow-expected.png: Added.
+ * platform/efl/css3/masking/clip-path-circle-overflow-expected.txt: Added.
+ * platform/efl/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
+ * platform/efl/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Added.
+ * platform/efl/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
+ * platform/efl/css3/masking/clip-path-circle-relative-overflow-expected.txt: Added.
+ * platform/efl/css3/masking/clip-path-ellipse-expected.png: Added.
+ * platform/efl/css3/masking/clip-path-ellipse-expected.txt: Added.
+ * platform/efl/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
+ * platform/efl/css3/masking/clip-path-polygon-evenodd-expected.txt: Added.
+ * platform/efl/css3/masking/clip-path-polygon-expected.png: Added.
+ * platform/efl/css3/masking/clip-path-polygon-expected.txt: Added.
+ * platform/efl/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
+ * platform/efl/css3/masking/clip-path-polygon-nonzero-expected.txt: Added.
+ * platform/efl/css3/masking/clip-path-rectangle-expected.png: Added.
+ * platform/efl/css3/masking/clip-path-rectangle-expected.txt: Added.
+
+2012-09-10 Christophe Dumez <[email protected]>
+
[EFL] Several CSS 2.1 need rebaseline after bug 93148
https://bugs.webkit.org/show_bug.cgi?id=96241
Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (128029 => 128030)
--- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-10 08:09:56 UTC (rev 128029)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-10 08:16:32 UTC (rev 128030)
@@ -152,9 +152,6 @@
// WebKitTestRunner needs an implementation for eventSender.scheduleAsynchronousClick
BUGWKEFL : fast/events/popup-blocking-click-in-iframe.html = TEXT
-// Interactive form validation setting is not enabled in WebKitTestRunner
-BUGWK95936 : fast/forms/number/number-interactive-validation-required.html = TEXT
-
// WebKitTestRunner eventSender needs touch events support
BUGWKEFL : fast/events/touch/basic-multi-touch-events-limited.html = TEXT
BUGWKEFL : fast/events/touch/basic-multi-touch-events.html = TEXT
Modified: trunk/LayoutTests/platform/qt-5.0-wk2/Skipped (128029 => 128030)
--- trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-09-10 08:09:56 UTC (rev 128029)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-09-10 08:16:32 UTC (rev 128030)
@@ -496,10 +496,6 @@
http/tests/security/cross-origin-plugin-private-browsing-toggled.html
http/tests/security/cross-origin-plugin.html
-# [Qt][WK2] New fast/forms/number/number-interactive-validation-required.html fails
-# https://bugs.webkit.org/show_bug.cgi?id=95936
-fast/forms/number/number-interactive-validation-required.html
-
# ENABLE(OVERFLOW_SCROLLING) is disabled (not enabled)
compositing/overflow/overflow-auto-with-touch-toggle.html
Modified: trunk/Source/WebKit2/ChangeLog (128029 => 128030)
--- trunk/Source/WebKit2/ChangeLog 2012-09-10 08:09:56 UTC (rev 128029)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-10 08:16:32 UTC (rev 128030)
@@ -1,3 +1,22 @@
+2012-09-10 Christophe Dumez <[email protected]>
+
+ [WK2] New fast/forms/number/number-interactive-validation-required.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=95936
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Add WKPreference private API for manipulate the interactive form
+ validation setting. This is now needed by WebKitTestRunner.
+
+ * Shared/WebPreferencesStore.h:
+ (WebKit):
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetInteractiveFormValidationEnabled):
+ (WKPreferencesGetInteractiveFormValidationEnabled):
+ * UIProcess/API/C/WKPreferencesPrivate.h:
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+
2012-09-09 Sam Weinig <[email protected]>
Simplify WebKit2 XPC service backend now that I know it doesn't need to soft link WebKit2.framework
Modified: trunk/Source/WebKit2/Shared/WebPreferencesStore.h (128029 => 128030)
--- trunk/Source/WebKit2/Shared/WebPreferencesStore.h 2012-09-10 08:09:56 UTC (rev 128029)
+++ trunk/Source/WebKit2/Shared/WebPreferencesStore.h 2012-09-10 08:16:32 UTC (rev 128030)
@@ -124,6 +124,7 @@
macro(AsynchronousPluginInitializationEnabledForAllPlugins, asynchronousPluginInitializationEnabledForAllPlugins, Bool, bool, false) \
macro(ArtificialPluginInitializationDelayEnabled, artificialPluginInitializationDelayEnabled, Bool, bool, false) \
macro(TabToLinksEnabled, tabToLinksEnabled, Bool, bool, false) \
+ macro(InteractiveFormValidationEnabled, interactiveFormValidationEnabled, Bool, bool, false) \
macro(ScrollingPerformanceLoggingEnabled, scrollingPerformanceLoggingEnabled, Bool, bool, false) \
macro(StorageBlockingPolicy, storageBlockingPolicy, UInt32, uint32_t, 0) \
macro(ScrollAnimatorEnabled, scrollAnimatorEnabled, Bool, bool, DEFAULT_WEBKIT_SCROLL_ANIMATOR_ENABLED) \
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (128029 => 128030)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2012-09-10 08:09:56 UTC (rev 128029)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2012-09-10 08:16:32 UTC (rev 128030)
@@ -884,6 +884,16 @@
return toImpl(preferencesRef)->tabToLinksEnabled();
}
+void WKPreferencesSetInteractiveFormValidationEnabled(WKPreferencesRef preferencesRef, bool enabled)
+{
+ toImpl(preferencesRef)->setInteractiveFormValidationEnabled(enabled);
+}
+
+bool WKPreferencesGetInteractiveFormValidationEnabled(WKPreferencesRef preferencesRef)
+{
+ return toImpl(preferencesRef)->interactiveFormValidationEnabled();
+}
+
void WKPreferencesSetScrollingPerformanceLoggingEnabled(WKPreferencesRef preferencesRef, bool enabled)
{
toImpl(preferencesRef)->setScrollingPerformanceLoggingEnabled(enabled);
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h (128029 => 128030)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h 2012-09-10 08:09:56 UTC (rev 128029)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h 2012-09-10 08:16:32 UTC (rev 128030)
@@ -208,6 +208,10 @@
WK_EXPORT bool WKPreferencesGetTabToLinksEnabled(WKPreferencesRef preferencesRef);
// Defaults to false
+WK_EXPORT void WKPreferencesSetInteractiveFormValidationEnabled(WKPreferencesRef preferencesRef, bool enabled);
+WK_EXPORT bool WKPreferencesGetInteractiveFormValidationEnabled(WKPreferencesRef preferencesRef);
+
+// Defaults to false
WK_EXPORT void WKPreferencesSetScrollingPerformanceLoggingEnabled(WKPreferencesRef preferencesRef, bool enabled);
WK_EXPORT bool WKPreferencesGetScrollingPerformanceLoggingEnabled(WKPreferencesRef preferencesRef);
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (128029 => 128030)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-09-10 08:09:56 UTC (rev 128029)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-09-10 08:16:32 UTC (rev 128030)
@@ -2072,6 +2072,7 @@
#if ENABLE(SMOOTH_SCROLLING)
settings->setEnableScrollAnimator(store.getBoolValueForKey(WebPreferencesKey::scrollAnimatorEnabledKey()));
#endif
+ settings->setInteractiveFormValidationEnabled(store.getBoolValueForKey(WebPreferencesKey::interactiveFormValidationEnabledKey()));
// <rdar://problem/10697417>: It is necessary to force compositing when accelerate drawing
// is enabled on Mac so that scrollbars are always in their own layers.
Modified: trunk/Tools/ChangeLog (128029 => 128030)
--- trunk/Tools/ChangeLog 2012-09-10 08:09:56 UTC (rev 128029)
+++ trunk/Tools/ChangeLog 2012-09-10 08:16:32 UTC (rev 128030)
@@ -1,3 +1,17 @@
+2012-09-10 Christophe Dumez <[email protected]>
+
+ [WK2] New fast/forms/number/number-interactive-validation-required.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=95936
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Enable interactive form validation setting in WebKitTestRunner as
+ we are currently doing in DumpRenderTree. This is needed for some
+ tests to pass.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::resetStateToConsistentValues):
+
2012-09-09 Zan Dobersek <[email protected]>
Clean up the code in XvfbDriver
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (128029 => 128030)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2012-09-10 08:09:56 UTC (rev 128029)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2012-09-10 08:16:32 UTC (rev 128030)
@@ -476,6 +476,7 @@
WKPreferencesSetAsynchronousPluginInitializationEnabledForAllPlugins(preferences, false);
WKPreferencesSetArtificialPluginInitializationDelayEnabled(preferences, false);
WKPreferencesSetTabToLinksEnabled(preferences, false);
+ WKPreferencesSetInteractiveFormValidationEnabled(preferences, true);
// [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
// FIXME: https://bugs.webkit.org/show_bug.cgi?id=76247
