Title: [128052] trunk/Tools
Revision
128052
Author
[email protected]
Date
2012-09-10 06:09:18 -0700 (Mon, 10 Sep 2012)

Log Message

[EFL][DRT] Encoding issue in printed console messages
https://bugs.webkit.org/show_bug.cgi?id=96263

Patch by Christophe Dumez <[email protected]> on 2012-09-10
Reviewed by Kenneth Rohde Christiansen.

Correctly handle CONSOLE messages that contain non-ascii
characters in EFL's DRT. We need to use String::fromUTF8()
to construct a WTF::String from a raw string.

* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onConsoleMessage):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (128051 => 128052)


--- trunk/Tools/ChangeLog	2012-09-10 13:08:13 UTC (rev 128051)
+++ trunk/Tools/ChangeLog	2012-09-10 13:09:18 UTC (rev 128052)
@@ -1,3 +1,17 @@
+2012-09-10  Christophe Dumez  <[email protected]>
+
+        [EFL][DRT] Encoding issue in printed console messages
+        https://bugs.webkit.org/show_bug.cgi?id=96263
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Correctly handle CONSOLE messages that contain non-ascii
+        characters in EFL's DRT. We need to use String::fromUTF8()
+        to construct a WTF::String from a raw string.
+
+        * DumpRenderTree/efl/DumpRenderTreeView.cpp:
+        (onConsoleMessage):
+
 2012-09-10  Mikhail Pozdnyakov  <[email protected]>
 
         [WK2][WTR] User style sheet location should be reset before each test

Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp (128051 => 128052)


--- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp	2012-09-10 13:08:13 UTC (rev 128051)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp	2012-09-10 13:09:18 UTC (rev 128052)
@@ -58,7 +58,7 @@
 static void onConsoleMessage(Ewk_View_Smart_Data*, const char* message, unsigned int lineNumber, const char*)
 {
     // Tests expect only the filename part of local URIs
-    WTF::String newMessage = message;
+    WTF::String newMessage = WTF::String::fromUTF8(message);
     if (!newMessage.isEmpty()) {
         const size_t fileProtocol = newMessage.find("file://");
         if (fileProtocol != WTF::notFound)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to