Title: [128072] trunk/LayoutTests
- Revision
- 128072
- Author
- [email protected]
- Date
- 2012-09-10 10:01:48 -0700 (Mon, 10 Sep 2012)
Log Message
REGRESSION (r127936): Multiple accessibility tests failing on Lion
https://bugs.webkit.org/show_bug.cgi?id=96173
Reviewed by Chris Fleizach.
This test (update-children-when-aria-role-changes.html) assumes that
an element with an aria-label is ignored, which worked before, but it's
not ignored anymore after r127936. One of the comments in
AccessibilityRenderObject.cpp says: "if this element has aria attributes on it,
it should not be ignored," so I think the test should be updated to not use
aria-label on an element we want to be ignored.
* platform/mac/Skipped:
* platform/mac/accessibility/update-children-when-aria-role-changes.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (128071 => 128072)
--- trunk/LayoutTests/ChangeLog 2012-09-10 16:59:24 UTC (rev 128071)
+++ trunk/LayoutTests/ChangeLog 2012-09-10 17:01:48 UTC (rev 128072)
@@ -1,3 +1,20 @@
+2012-09-10 Dominic Mazzoni <[email protected]>
+
+ REGRESSION (r127936): Multiple accessibility tests failing on Lion
+ https://bugs.webkit.org/show_bug.cgi?id=96173
+
+ Reviewed by Chris Fleizach.
+
+ This test (update-children-when-aria-role-changes.html) assumes that
+ an element with an aria-label is ignored, which worked before, but it's
+ not ignored anymore after r127936. One of the comments in
+ AccessibilityRenderObject.cpp says: "if this element has aria attributes on it,
+ it should not be ignored," so I think the test should be updated to not use
+ aria-label on an element we want to be ignored.
+
+ * platform/mac/Skipped:
+ * platform/mac/accessibility/update-children-when-aria-role-changes.html:
+
2012-09-10 Mike West <[email protected]>
Console warnings generated by script access to sandboxed iframes should make the violation clear.
Modified: trunk/LayoutTests/platform/mac/Skipped (128071 => 128072)
--- trunk/LayoutTests/platform/mac/Skipped 2012-09-10 16:59:24 UTC (rev 128071)
+++ trunk/LayoutTests/platform/mac/Skipped 2012-09-10 17:01:48 UTC (rev 128072)
@@ -78,10 +78,6 @@
accessibility/menu-list-sends-change-notification.html
accessibility/multiselect-list-reports-active-option.html
-# Test needs a minor fix.
-# https://bugs.webkit.org/show_bug.cgi?id=96173
-platform/mac/accessibility/update-children-when-aria-role-changes.html
-
# Need to add functionality to DumpRenderTree to handle error pages
fast/history/back-forward-reset-after-error-handling.html
Modified: trunk/LayoutTests/platform/mac/accessibility/update-children-when-aria-role-changes.html (128071 => 128072)
--- trunk/LayoutTests/platform/mac/accessibility/update-children-when-aria-role-changes.html 2012-09-10 16:59:24 UTC (rev 128071)
+++ trunk/LayoutTests/platform/mac/accessibility/update-children-when-aria-role-changes.html 2012-09-10 17:01:48 UTC (rev 128072)
@@ -11,7 +11,7 @@
<div id="parent" tabindex=0 role="group">
<span tabindex=0 role="button" id="button1">button 1</span>
- <span tabindex=0 id="button2" aria-label="button 2"></span>
+ <span tabindex=0 id="button2" title="button 2"></span>
</div>
<p id="description"></p>
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
