Title: [128074] trunk/Source/WebCore
Revision
128074
Author
[email protected]
Date
2012-09-10 10:12:55 -0700 (Mon, 10 Sep 2012)

Log Message

[GTK][a11y] editing/pasteboard/paste-blockquote-into-blockquote-4.html crashes
https://bugs.webkit.org/show_bug.cgi?id=96199

Patch by Joanmarie Diggs <[email protected]> on 2012-09-10
Reviewed by Martin Robinson.

Added sanity check to correct erroneous assumption that there will
always be a child object.

No new tests as the bug crashes two existing Layout Tests which should
no longer crash as a result of this fix.

* accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (128073 => 128074)


--- trunk/Source/WebCore/ChangeLog	2012-09-10 17:05:27 UTC (rev 128073)
+++ trunk/Source/WebCore/ChangeLog	2012-09-10 17:12:55 UTC (rev 128074)
@@ -1,3 +1,19 @@
+2012-09-10  Joanmarie Diggs  <[email protected]>
+
+        [GTK][a11y] editing/pasteboard/paste-blockquote-into-blockquote-4.html crashes
+        https://bugs.webkit.org/show_bug.cgi?id=96199
+
+        Reviewed by Martin Robinson.
+
+        Added sanity check to correct erroneous assumption that there will
+        always be a child object.
+
+        No new tests as the bug crashes two existing Layout Tests which should
+        no longer crash as a result of this fix.
+
+        * accessibility/gtk/AccessibilityObjectAtk.cpp:
+        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
+
 2012-09-10  Mike West  <[email protected]>
 
         Clarify the cause of console warnings generated by "cross-origin" access to sandboxed iframes.

Modified: trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp (128073 => 128074)


--- trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp	2012-09-10 17:05:27 UTC (rev 128073)
+++ trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp	2012-09-10 17:12:55 UTC (rev 128074)
@@ -89,7 +89,7 @@
             return DefaultBehavior;
 
         child = child->firstChild();
-        if (child->isLink() || !child->firstAnonymousBlockChild())
+        if (child && (child->isLink() || !child->firstAnonymousBlockChild()))
             return IncludeObject;
     }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to