Title: [128086] trunk/Tools
- Revision
- 128086
- Author
- [email protected]
- Date
- 2012-09-10 11:50:54 -0700 (Mon, 10 Sep 2012)
Log Message
WKTR often reports an unresponsive WebProcess on Mac bots
https://bugs.webkit.org/show_bug.cgi?id=95906
Reviewed by Dan Bernstein.
Attempt to work around resource contention issues by increasing the NRWT
timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
* WebKitTestRunner/TestController.cpp:
(WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (128085 => 128086)
--- trunk/Tools/ChangeLog 2012-09-10 18:49:07 UTC (rev 128085)
+++ trunk/Tools/ChangeLog 2012-09-10 18:50:54 UTC (rev 128086)
@@ -1,3 +1,18 @@
+2012-09-10 Tim Horton <[email protected]>
+
+ WKTR often reports an unresponsive WebProcess on Mac bots
+ https://bugs.webkit.org/show_bug.cgi?id=95906
+
+ Reviewed by Dan Bernstein.
+
+ Attempt to work around resource contention issues by increasing the NRWT
+ timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
+
+ * Scripts/webkitpy/layout_tests/port/base.py:
+ (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
+ * WebKitTestRunner/TestController.cpp:
+ (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
+
2012-09-07 Jer Noble <[email protected]>
<audio> and <video> should send Do Not Track when appropriate
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (128085 => 128086)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2012-09-10 18:49:07 UTC (rev 128085)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2012-09-10 18:50:54 UTC (rev 128086)
@@ -156,7 +156,7 @@
if self.get_option('webkit_test_runner'):
# Add some more time to WebKitTestRunner because it needs to syncronise the state
# with the web process and we want to detect if there is a problem with that in the driver.
- return 50 * 1000
+ return 80 * 1000
return 35 * 1000
def driver_stop_timeout(self):
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (128085 => 128086)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2012-09-10 18:49:07 UTC (rev 128085)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2012-09-10 18:50:54 UTC (rev 128086)
@@ -55,10 +55,10 @@
namespace WTR {
-// defaultLongTimeout + defaultShortTimeout should be less than 50,
+// defaultLongTimeout + defaultShortTimeout should be less than 80,
// the default timeout value of the test harness so we can detect an
// unresponsive web process.
-static const double defaultLongTimeout = 30;
+static const double defaultLongTimeout = 60;
static const double defaultShortTimeout = 15;
static const double defaultNoTimeout = -1;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
