[webkit-changes] [128100] trunk/Source/JavaScriptCore

Mon, 10 Sep 2012 13:50:36 -0700

Title: [128100] trunk/Source/_javascript_Core
Revision
128100
Author
[email protected]
Date
2012-09-10 13:51:13 -0700 (Mon, 10 Sep 2012)

Log Message

offlineasm has some impossible to implement, and unused, instructions
https://bugs.webkit.org/show_bug.cgi?id=96310

Reviewed by Mark Hahnenberg.

* offlineasm/armv7.rb:
* offlineasm/instructions.rb:
* offlineasm/x86.rb:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (128099 => 128100)


--- trunk/Source/_javascript_Core/ChangeLog	2012-09-10 20:33:11 UTC (rev 128099)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-09-10 20:51:13 UTC (rev 128100)
@@ -1,3 +1,14 @@
+2012-09-10  Filip Pizlo  <[email protected]>
+
+        offlineasm has some impossible to implement, and unused, instructions
+        https://bugs.webkit.org/show_bug.cgi?id=96310
+
+        Reviewed by Mark Hahnenberg.
+
+        * offlineasm/armv7.rb:
+        * offlineasm/instructions.rb:
+        * offlineasm/x86.rb:
+
 2012-09-09  Geoffrey Garen  <[email protected]>
 
         Refactored op_tear_off* to support activations that don't allocate space for 'arguments'

Modified: trunk/Source/_javascript_Core/offlineasm/armv7.rb (128099 => 128100)


--- trunk/Source/_javascript_Core/offlineasm/armv7.rb	2012-09-10 20:33:11 UTC (rev 128099)
+++ trunk/Source/_javascript_Core/offlineasm/armv7.rb	2012-09-10 20:51:13 UTC (rev 128100)
@@ -527,8 +527,8 @@
                                            node.opcode,
                                            armV7AsRegisters(newList, postInstructions, node.operands, "i"),
                                            annotation)
-            when "bbeq", "bbneq", "bba", "bbaeq", "bbb", "bbbeq", "btbo", "btbz", "btbnz", "tbz", "tbnz",
-                "tbo", "cbeq", "cbneq", "cba", "cbaeq", "cbb", "cbbeq"
+            when "bbeq", "bbneq", "bba", "bbaeq", "bbb", "bbbeq", "btbz", "btbnz", "tbz", "tbnz",
+                "cbeq", "cbneq", "cba", "cbaeq", "cbb", "cbbeq"
                 newList << Instruction.new(node.codeOrigin,
                                            node.opcode,
                                            armV7AsRegisters(newList, postInstructions, node.operands, "b"),
@@ -579,8 +579,8 @@
             case node.opcode
             when "cieq", "cineq", "cia", "ciaeq", "cib", "cibeq", "cigt", "cigteq", "cilt", "cilteq",
                 "cpeq", "cpneq", "cpa", "cpaeq", "cpb", "cpbeq", "cpgt", "cpgteq", "cplt", "cplteq",
-                "tio", "tis", "tiz", "tinz", "tbo", "tbs", "tbz", "tbnz", "tpo", "tps", "tpz", "tpnz",
-                "cbeq", "cbneq", "cba", "cbaeq", "cbb", "cbbeq", "cbgt", "cbgteq", "cblt", "cblteq"
+                "tis", "tiz", "tinz", "tbs", "tbz", "tbnz", "tps", "tpz", "tpnz", "cbeq", "cbneq",
+                "cba", "cbaeq", "cbb", "cbbeq", "cbgt", "cbgteq", "cblt", "cblteq"
                 if node.operands.size == 2
                     if node.operands[0] == node.operands[1]
                         tmp = Tmp.new(node.codeOrigin, :gpr)
@@ -940,9 +940,6 @@
         when "btinz", "btpnz", "btbnz"
             emitArmV7Test(operands)
             $asm.puts "bne #{operands[-1].asmLabel}"
-        when "btio", "btpo", "btbo"
-            emitArmV7Test(operands)
-            $asm.puts "bvs #{operands[-1].asmLabel}"
         when "btis", "btps", "btbs"
             emitArmV7Test(operands)
             $asm.puts "bmi #{operands[-1].asmLabel}"
@@ -982,8 +979,6 @@
             emitArmV7Compare(operands, "lt")
         when "cilteq", "cplteq", "cblteq"
             emitArmV7Compare(operands, "le")
-        when "tio", "tbo", "tpo"
-            emitArmV7TestSet(operands, "vs")
         when "tis", "tbs", "tps"
             emitArmV7TestSet(operands, "mi")
         when "tiz", "tbz", "tpz"

Modified: trunk/Source/_javascript_Core/offlineasm/instructions.rb (128099 => 128100)


--- trunk/Source/_javascript_Core/offlineasm/instructions.rb	2012-09-10 20:33:11 UTC (rev 128099)
+++ trunk/Source/_javascript_Core/offlineasm/instructions.rb	2012-09-10 20:51:13 UTC (rev 128100)
@@ -107,11 +107,9 @@
      "bbgteq",
      "bblt",
      "bblteq",
-     "btio",
      "btis",
      "btiz",
      "btinz",
-     "btbo",
      "btbs",
      "btbz",
      "btbnz",
@@ -155,15 +153,12 @@
      "cigteq",
      "cilt",
      "cilteq",
-     "tio",
      "tis",
      "tiz",
      "tinz",
-     "tbo",
      "tbs",
      "tbz",
      "tbnz",
-     "tpo",
      "tps",
      "tpz",
      "tpnz",
@@ -197,7 +192,6 @@
      "cplt",
      "cplteq",
      "storep",
-     "btpo",
      "btps",
      "btpz",
      "btpnz",

Modified: trunk/Source/_javascript_Core/offlineasm/x86.rb (128099 => 128100)


--- trunk/Source/_javascript_Core/offlineasm/x86.rb	2012-09-10 20:33:11 UTC (rev 128099)
+++ trunk/Source/_javascript_Core/offlineasm/x86.rb	2012-09-10 20:51:13 UTC (rev 128100)
@@ -835,10 +835,6 @@
             handleX86IntBranch("jl", :byte)
         when "bblteq"
             handleX86IntBranch("jlteq", :byte)
-        when "btio"
-            handleX86BranchTest("jo", :int)
-        when "btpo"
-            handleX86BranchTest("jo", :ptr)
         when "btis"
             handleX86BranchTest("js", :int)
         when "btps"
@@ -851,8 +847,6 @@
             handleX86BranchTest("jnz", :int)
         when "btpnz"
             handleX86BranchTest("jnz", :ptr)
-        when "btbo"
-            handleX86BranchTest("jo", :byte)
         when "btbs"
             handleX86BranchTest("js", :byte)
         when "btbz"
@@ -967,24 +961,18 @@
             handleX86IntCompareSet("setle", :byte)
         when "cplteq"
             handleX86IntCompareSet("setle", :ptr)
-        when "tio"
-            handleX86SetTest("seto", :int)
         when "tis"
             handleX86SetTest("sets", :int)
         when "tiz"
             handleX86SetTest("setz", :int)
         when "tinz"
             handleX86SetTest("setnz", :int)
-        when "tpo"
-            handleX86SetTest("seto", :ptr)
         when "tps"
             handleX86SetTest("sets", :ptr)
         when "tpz"
             handleX86SetTest("setz", :ptr)
         when "tpnz"
             handleX86SetTest("setnz", :ptr)
-        when "tbo"
-            handleX86SetTest("seto", :byte)
         when "tbs"
             handleX86SetTest("sets", :byte)
         when "tbz"

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to