Title: [128107] trunk/Source/WebCore
- Revision
- 128107
- Author
- [email protected]
- Date
- 2012-09-10 14:41:14 -0700 (Mon, 10 Sep 2012)
Log Message
Remove stray spaces found after :: in case statements
https://bugs.webkit.org/show_bug.cgi?id=96314
Reviewed by Ojan Vafai.
New contributors keep copy/pasting this style error and it makes me sad.
Also remove the extra spaces in MediaQueryEvaluator.cpp.
No new tests, this is just a style refactor.
* css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::unitCategory):
* css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::MediaQueryEvaluator):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (128106 => 128107)
--- trunk/Source/WebCore/ChangeLog 2012-09-10 21:18:15 UTC (rev 128106)
+++ trunk/Source/WebCore/ChangeLog 2012-09-10 21:41:14 UTC (rev 128107)
@@ -1,3 +1,21 @@
+2012-09-10 Tony Chang <[email protected]>
+
+ Remove stray spaces found after :: in case statements
+ https://bugs.webkit.org/show_bug.cgi?id=96314
+
+ Reviewed by Ojan Vafai.
+
+ New contributors keep copy/pasting this style error and it makes me sad.
+ Also remove the extra spaces in MediaQueryEvaluator.cpp.
+
+ No new tests, this is just a style refactor.
+
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::isValidCSSUnitTypeForDoubleConversion):
+ (WebCore::unitCategory):
+ * css/MediaQueryEvaluator.cpp:
+ (WebCore::MediaQueryEvaluator::MediaQueryEvaluator):
+
2012-09-10 Adam Barth <[email protected]>
[V8] setNamedHiddenWindowReference doesn't need to be a special case
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.cpp (128106 => 128107)
--- trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2012-09-10 21:18:15 UTC (rev 128106)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2012-09-10 21:41:14 UTC (rev 128107)
@@ -56,65 +56,65 @@
static inline bool isValidCSSUnitTypeForDoubleConversion(CSSPrimitiveValue::UnitTypes unitType)
{
switch (unitType) {
- case CSSPrimitiveValue:: CSS_CALC:
- case CSSPrimitiveValue:: CSS_CALC_PERCENTAGE_WITH_NUMBER:
- case CSSPrimitiveValue:: CSS_CALC_PERCENTAGE_WITH_LENGTH:
- case CSSPrimitiveValue:: CSS_CM:
- case CSSPrimitiveValue:: CSS_DEG:
- case CSSPrimitiveValue:: CSS_DIMENSION:
+ case CSSPrimitiveValue::CSS_CALC:
+ case CSSPrimitiveValue::CSS_CALC_PERCENTAGE_WITH_NUMBER:
+ case CSSPrimitiveValue::CSS_CALC_PERCENTAGE_WITH_LENGTH:
+ case CSSPrimitiveValue::CSS_CM:
+ case CSSPrimitiveValue::CSS_DEG:
+ case CSSPrimitiveValue::CSS_DIMENSION:
#if ENABLE(CSS_IMAGE_RESOLUTION)
- case CSSPrimitiveValue:: CSS_DPPX:
- case CSSPrimitiveValue:: CSS_DPI:
- case CSSPrimitiveValue:: CSS_DPCM:
+ case CSSPrimitiveValue::CSS_DPPX:
+ case CSSPrimitiveValue::CSS_DPI:
+ case CSSPrimitiveValue::CSS_DPCM:
#endif
- case CSSPrimitiveValue:: CSS_EMS:
- case CSSPrimitiveValue:: CSS_EXS:
- case CSSPrimitiveValue:: CSS_GRAD:
- case CSSPrimitiveValue:: CSS_HZ:
- case CSSPrimitiveValue:: CSS_IN:
- case CSSPrimitiveValue:: CSS_KHZ:
- case CSSPrimitiveValue:: CSS_MM:
- case CSSPrimitiveValue:: CSS_MS:
- case CSSPrimitiveValue:: CSS_NUMBER:
- case CSSPrimitiveValue:: CSS_PERCENTAGE:
- case CSSPrimitiveValue:: CSS_PC:
- case CSSPrimitiveValue:: CSS_PT:
- case CSSPrimitiveValue:: CSS_PX:
- case CSSPrimitiveValue:: CSS_RAD:
- case CSSPrimitiveValue:: CSS_REMS:
- case CSSPrimitiveValue:: CSS_S:
- case CSSPrimitiveValue:: CSS_TURN:
- case CSSPrimitiveValue:: CSS_VW:
- case CSSPrimitiveValue:: CSS_VH:
- case CSSPrimitiveValue:: CSS_VMIN:
+ case CSSPrimitiveValue::CSS_EMS:
+ case CSSPrimitiveValue::CSS_EXS:
+ case CSSPrimitiveValue::CSS_GRAD:
+ case CSSPrimitiveValue::CSS_HZ:
+ case CSSPrimitiveValue::CSS_IN:
+ case CSSPrimitiveValue::CSS_KHZ:
+ case CSSPrimitiveValue::CSS_MM:
+ case CSSPrimitiveValue::CSS_MS:
+ case CSSPrimitiveValue::CSS_NUMBER:
+ case CSSPrimitiveValue::CSS_PERCENTAGE:
+ case CSSPrimitiveValue::CSS_PC:
+ case CSSPrimitiveValue::CSS_PT:
+ case CSSPrimitiveValue::CSS_PX:
+ case CSSPrimitiveValue::CSS_RAD:
+ case CSSPrimitiveValue::CSS_REMS:
+ case CSSPrimitiveValue::CSS_S:
+ case CSSPrimitiveValue::CSS_TURN:
+ case CSSPrimitiveValue::CSS_VW:
+ case CSSPrimitiveValue::CSS_VH:
+ case CSSPrimitiveValue::CSS_VMIN:
return true;
- case CSSPrimitiveValue:: CSS_ATTR:
- case CSSPrimitiveValue:: CSS_COUNTER:
- case CSSPrimitiveValue:: CSS_COUNTER_NAME:
+ case CSSPrimitiveValue::CSS_ATTR:
+ case CSSPrimitiveValue::CSS_COUNTER:
+ case CSSPrimitiveValue::CSS_COUNTER_NAME:
#if ENABLE(DASHBOARD_SUPPORT) || ENABLE(WIDGET_REGION)
- case CSSPrimitiveValue:: CSS_DASHBOARD_REGION:
+ case CSSPrimitiveValue::CSS_DASHBOARD_REGION:
#endif
#if !ENABLE(CSS_IMAGE_RESOLUTION)
- case CSSPrimitiveValue:: CSS_DPPX:
- case CSSPrimitiveValue:: CSS_DPI:
- case CSSPrimitiveValue:: CSS_DPCM:
+ case CSSPrimitiveValue::CSS_DPPX:
+ case CSSPrimitiveValue::CSS_DPI:
+ case CSSPrimitiveValue::CSS_DPCM:
#endif
- case CSSPrimitiveValue:: CSS_IDENT:
- case CSSPrimitiveValue:: CSS_PAIR:
- case CSSPrimitiveValue:: CSS_PARSER_HEXCOLOR:
- case CSSPrimitiveValue:: CSS_PARSER_IDENTIFIER:
- case CSSPrimitiveValue:: CSS_PARSER_INTEGER:
- case CSSPrimitiveValue:: CSS_PARSER_OPERATOR:
- case CSSPrimitiveValue:: CSS_RECT:
- case CSSPrimitiveValue:: CSS_QUAD:
- case CSSPrimitiveValue:: CSS_RGBCOLOR:
- case CSSPrimitiveValue:: CSS_SHAPE:
- case CSSPrimitiveValue:: CSS_STRING:
- case CSSPrimitiveValue:: CSS_UNICODE_RANGE:
- case CSSPrimitiveValue:: CSS_UNKNOWN:
- case CSSPrimitiveValue:: CSS_URI:
+ case CSSPrimitiveValue::CSS_IDENT:
+ case CSSPrimitiveValue::CSS_PAIR:
+ case CSSPrimitiveValue::CSS_PARSER_HEXCOLOR:
+ case CSSPrimitiveValue::CSS_PARSER_IDENTIFIER:
+ case CSSPrimitiveValue::CSS_PARSER_INTEGER:
+ case CSSPrimitiveValue::CSS_PARSER_OPERATOR:
+ case CSSPrimitiveValue::CSS_RECT:
+ case CSSPrimitiveValue::CSS_QUAD:
+ case CSSPrimitiveValue::CSS_RGBCOLOR:
+ case CSSPrimitiveValue::CSS_SHAPE:
+ case CSSPrimitiveValue::CSS_STRING:
+ case CSSPrimitiveValue::CSS_UNICODE_RANGE:
+ case CSSPrimitiveValue::CSS_UNKNOWN:
+ case CSSPrimitiveValue::CSS_URI:
#if ENABLE(CSS_VARIABLES)
- case CSSPrimitiveValue:: CSS_VARIABLE_NAME:
+ case CSSPrimitiveValue::CSS_VARIABLE_NAME:
#endif
return false;
}
@@ -155,9 +155,9 @@
case CSSPrimitiveValue::CSS_VMIN:
return CSSPrimitiveValue::UViewportPercentageLength;
#if ENABLE(CSS_IMAGE_RESOLUTION)
- case CSSPrimitiveValue:: CSS_DPPX:
- case CSSPrimitiveValue:: CSS_DPI:
- case CSSPrimitiveValue:: CSS_DPCM:
+ case CSSPrimitiveValue::CSS_DPPX:
+ case CSSPrimitiveValue::CSS_DPI:
+ case CSSPrimitiveValue::CSS_DPCM:
return CSSPrimitiveValue::UResolution;
#endif
default:
Modified: trunk/Source/WebCore/css/MediaQueryEvaluator.cpp (128106 => 128107)
--- trunk/Source/WebCore/css/MediaQueryEvaluator.cpp 2012-09-10 21:18:15 UTC (rev 128106)
+++ trunk/Source/WebCore/css/MediaQueryEvaluator.cpp 2012-09-10 21:41:14 UTC (rev 128107)
@@ -82,7 +82,7 @@
{
}
-MediaQueryEvaluator:: MediaQueryEvaluator(const String& acceptedMediaType, bool mediaFeatureResult)
+MediaQueryEvaluator::MediaQueryEvaluator(const String& acceptedMediaType, bool mediaFeatureResult)
: m_mediaType(acceptedMediaType)
, m_frame(0)
, m_style(0)
@@ -90,7 +90,7 @@
{
}
-MediaQueryEvaluator:: MediaQueryEvaluator(const char* acceptedMediaType, bool mediaFeatureResult)
+MediaQueryEvaluator::MediaQueryEvaluator(const char* acceptedMediaType, bool mediaFeatureResult)
: m_mediaType(acceptedMediaType)
, m_frame(0)
, m_style(0)
@@ -98,7 +98,7 @@
{
}
-MediaQueryEvaluator:: MediaQueryEvaluator(const String& acceptedMediaType, Frame* frame, RenderStyle* style)
+MediaQueryEvaluator::MediaQueryEvaluator(const String& acceptedMediaType, Frame* frame, RenderStyle* style)
: m_mediaType(acceptedMediaType)
, m_frame(frame)
, m_style(style)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
