Title: [128163] trunk/Source/WebKit2
- Revision
- 128163
- Author
- [email protected]
- Date
- 2012-09-11 03:06:58 -0700 (Tue, 11 Sep 2012)
Log Message
[WK2][EFL] Fix compile warnings when enable tiled backing store
https://bugs.webkit.org/show_bug.cgi?id=95342
Patch by Kangil Han <[email protected]> on 2012-09-11
Reviewed by Gyuyoung Kim.
Fixed compile time warning messages when enable tiled backing store.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_accelerated_compositing_mode_enter): Fixed invalid use of 'EINA_SAFETY_ON_NULL_RETURN_VAL' since it used '!' ahead of evasGl value so it is always null.
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setChildren): Replaced 'int' i with 'unsigned' because its comparing value is 'size_t'.
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::renderNextFrame): Replaced 'int' i with 'unsigned' because its comparing value is 'size_t'.
(WebKit::LayerTreeCoordinator::beginContentUpdate): Replaced 'int' i with 'unsigned' because its comparing value is 'size_t'.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (128162 => 128163)
--- trunk/Source/WebKit2/ChangeLog 2012-09-11 09:57:38 UTC (rev 128162)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-11 10:06:58 UTC (rev 128163)
@@ -1,3 +1,20 @@
+2012-09-11 Kangil Han <[email protected]>
+
+ [WK2][EFL] Fix compile warnings when enable tiled backing store
+ https://bugs.webkit.org/show_bug.cgi?id=95342
+
+ Reviewed by Gyuyoung Kim.
+
+ Fixed compile time warning messages when enable tiled backing store.
+
+ * UIProcess/API/efl/ewk_view.cpp:
+ (ewk_view_accelerated_compositing_mode_enter): Fixed invalid use of 'EINA_SAFETY_ON_NULL_RETURN_VAL' since it used '!' ahead of evasGl value so it is always null.
+ * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
+ (WebCore::CoordinatedGraphicsLayer::setChildren): Replaced 'int' i with 'unsigned' because its comparing value is 'size_t'.
+ * WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
+ (WebKit::LayerTreeCoordinator::renderNextFrame): Replaced 'int' i with 'unsigned' because its comparing value is 'size_t'.
+ (WebKit::LayerTreeCoordinator::beginContentUpdate): Replaced 'int' i with 'unsigned' because its comparing value is 'size_t'.
+
2012-09-11 Byungwoo Lee <[email protected]>
[EFL][WK2] WKEinaSharedString needs a function to adopt eina stringshare.
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (128162 => 128163)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-09-11 09:57:38 UTC (rev 128162)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-09-11 10:06:58 UTC (rev 128163)
@@ -498,7 +498,7 @@
EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, false);
EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false);
- EINA_SAFETY_ON_NULL_RETURN_VAL(!priv->evasGl, false);
+ EINA_SAFETY_ON_NULL_RETURN_VAL(priv->evasGl, false);
Evas* evas = evas_object_evas_get(ewkView);
priv->evasGl = evas_gl_new(evas);
Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp (128162 => 128163)
--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp 2012-09-11 09:57:38 UTC (rev 128162)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp 2012-09-11 10:06:58 UTC (rev 128163)
@@ -151,7 +151,7 @@
bool ok = GraphicsLayer::setChildren(children);
if (!ok)
return false;
- for (int i = 0; i < children.size(); ++i) {
+ for (unsigned i = 0; i < children.size(); ++i) {
CoordinatedGraphicsLayer* child = toCoordinatedGraphicsLayer(children[i]);
child->setCoordinatedGraphicsLayerClient(m_CoordinatedGraphicsLayerClient);
child->didChangeLayerState();
Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp (128162 => 128163)
--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp 2012-09-11 09:57:38 UTC (rev 128162)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp 2012-09-11 10:06:58 UTC (rev 128163)
@@ -600,7 +600,7 @@
{
m_waitingForUIProcess = false;
scheduleLayerFlush();
- for (int i = 0; i < m_updateAtlases.size(); ++i)
+ for (unsigned i = 0; i < m_updateAtlases.size(); ++i)
m_updateAtlases[i]->didSwapBuffers();
}
@@ -622,7 +622,7 @@
PassOwnPtr<WebCore::GraphicsContext> LayerTreeCoordinator::beginContentUpdate(const WebCore::IntSize& size, ShareableBitmap::Flags flags, ShareableSurface::Handle& handle, WebCore::IntPoint& offset)
{
OwnPtr<WebCore::GraphicsContext> graphicsContext;
- for (int i = 0; i < m_updateAtlases.size(); ++i) {
+ for (unsigned i = 0; i < m_updateAtlases.size(); ++i) {
UpdateAtlas* atlas = m_updateAtlases[i].get();
if (atlas->flags() == flags) {
// This will return null if there is no available buffer space.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
