Diff
Modified: trunk/LayoutTests/ChangeLog (128185 => 128186)
--- trunk/LayoutTests/ChangeLog 2012-09-11 14:47:21 UTC (rev 128185)
+++ trunk/LayoutTests/ChangeLog 2012-09-11 14:49:53 UTC (rev 128186)
@@ -1,3 +1,14 @@
+2012-09-11 Mikhail Pozdnyakov <[email protected]>
+
+ [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
+ https://bugs.webkit.org/show_bug.cgi?id=96269
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Unskipped fast/spatial-navigation tests. Put those which still fail to an appropriate group.
+
+ * platform/wk2/Skipped:
+
2012-09-11 Philippe Liard <[email protected]>
Support LayoutTests on non-rooted Android devices.
Modified: trunk/LayoutTests/platform/wk2/Skipped (128185 => 128186)
--- trunk/LayoutTests/platform/wk2/Skipped 2012-09-11 14:47:21 UTC (rev 128185)
+++ trunk/LayoutTests/platform/wk2/Skipped 2012-09-11 14:49:53 UTC (rev 128186)
@@ -732,9 +732,6 @@
# WebKitTestRunner needs layoutTestController.hasGrammarMarker
editing/spelling/grammar.html
-# WebKitTestRunner needs layoutTestController.setSpatialNavigationEnabled
-fast/spatial-navigation
-
# WebKitTestRunner needs layoutTestController.dumpUserGestureInFrameLoadCallbacks
fast/frames/location-redirect-user-gesture.html
fast/frames/meta-refresh-user-gesture.html
@@ -901,6 +898,14 @@
webarchive/loading/test-loading-archive.html
webarchive/loading/test-loading-archive-subresource-null-mimetype.html
+# Some elements are skipped when focus is moved.
+fast/spatial-navigation/snav-container-white-space.html
+fast/spatial-navigation/snav-div-overflow-scrol-hidden.html
+fast/spatial-navigation/snav-fully-aligned-horizontally.html
+fast/spatial-navigation/snav-fully-aligned-vertically.html
+fast/spatial-navigation/snav-iframe-no-scrollable-content.html
+fast/spatial-navigation/snav-imagemap-overlapped-areas.html
+
### END OF (2) Classified failures without bug reports (yet)
########################################
Modified: trunk/Source/WebKit2/ChangeLog (128185 => 128186)
--- trunk/Source/WebKit2/ChangeLog 2012-09-11 14:47:21 UTC (rev 128185)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-11 14:49:53 UTC (rev 128186)
@@ -1,3 +1,21 @@
+2012-09-11 Mikhail Pozdnyakov <[email protected]>
+
+ [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
+ https://bugs.webkit.org/show_bug.cgi?id=96269
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Added a new setter for spacial navigation enabling to Injected Bundle private API.
+
+ * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
+ (WKBundleSetSpatialNavigationEnabled):
+ * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::setSpatialNavigationEnabled):
+ (WebKit):
+ * WebProcess/InjectedBundle/InjectedBundle.h:
+ (InjectedBundle):
+
2012-09-11 Marcelo Lira <[email protected]>
[Qt][WK2] Page loading status API lacks a status for intentionally stopped loading
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp (128185 => 128186)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2012-09-11 14:47:21 UTC (rev 128185)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2012-09-11 14:49:53 UTC (rev 128186)
@@ -191,6 +191,11 @@
toImpl(bundleRef)->setAuthorAndUserStylesEnabled(toImpl(pageGroupRef), enabled);
}
+void WKBundleSetSpatialNavigationEnabled(WKBundleRef bundleRef, WKBundlePageGroupRef pageGroupRef, bool enabled)
+{
+ toImpl(bundleRef)->setSpatialNavigationEnabled(toImpl(pageGroupRef), enabled);
+}
+
void WKBundleAddOriginAccessWhitelistEntry(WKBundleRef bundleRef, WKStringRef sourceOrigin, WKStringRef destinationProtocol, WKStringRef destinationHost, bool allowDestinationSubdomains)
{
toImpl(bundleRef)->addOriginAccessWhitelistEntry(toImpl(sourceOrigin)->string(), toImpl(destinationProtocol)->string(), toImpl(destinationHost)->string(), allowDestinationSubdomains);
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h (128185 => 128186)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h 2012-09-11 14:47:21 UTC (rev 128185)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h 2012-09-11 14:49:53 UTC (rev 128186)
@@ -66,6 +66,7 @@
WK_EXPORT void WKBundleSetPopupBlockingEnabled(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled);
WK_EXPORT void WKBundleSwitchNetworkLoaderToNewTestingSession(WKBundleRef bundle);
WK_EXPORT void WKBundleSetAuthorAndUserStylesEnabled(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled);
+WK_EXPORT void WKBundleSetSpatialNavigationEnabled(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled);
WK_EXPORT void WKBundleAddOriginAccessWhitelistEntry(WKBundleRef bundle, WKStringRef, WKStringRef, WKStringRef, bool);
WK_EXPORT void WKBundleRemoveOriginAccessWhitelistEntry(WKBundleRef bundle, WKStringRef, WKStringRef, WKStringRef, bool);
WK_EXPORT void WKBundleResetOriginAccessWhitelists(WKBundleRef bundle);
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (128185 => 128186)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2012-09-11 14:47:21 UTC (rev 128185)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2012-09-11 14:49:53 UTC (rev 128186)
@@ -293,6 +293,13 @@
(*iter)->settings()->setAuthorAndUserStylesEnabled(enabled);
}
+void InjectedBundle::setSpatialNavigationEnabled(WebPageGroupProxy* pageGroup, bool enabled)
+{
+ const HashSet<Page*>& pages = PageGroup::pageGroup(pageGroup->identifier())->pages();
+ for (HashSet<Page*>::iterator iter = pages.begin(); iter != pages.end(); ++iter)
+ (*iter)->settings()->setSpatialNavigationEnabled(enabled);
+}
+
void InjectedBundle::addOriginAccessWhitelistEntry(const String& sourceOrigin, const String& destinationProtocol, const String& destinationHost, bool allowDestinationSubdomains)
{
SecurityPolicy::addOriginAccessWhitelistEntry(*SecurityOrigin::createFromString(sourceOrigin), destinationProtocol, destinationHost, allowDestinationSubdomains);
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h (128185 => 128186)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h 2012-09-11 14:47:21 UTC (rev 128185)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h 2012-09-11 14:49:53 UTC (rev 128186)
@@ -117,6 +117,7 @@
void setPopupBlockingEnabled(WebPageGroupProxy*, bool);
void switchNetworkLoaderToNewTestingSession();
void setAuthorAndUserStylesEnabled(WebPageGroupProxy*, bool);
+ void setSpatialNavigationEnabled(WebPageGroupProxy*, bool);
void addOriginAccessWhitelistEntry(const String&, const String&, const String&, bool);
void removeOriginAccessWhitelistEntry(const String&, const String&, const String&, bool);
void resetOriginAccessWhitelists();
Modified: trunk/Tools/ChangeLog (128185 => 128186)
--- trunk/Tools/ChangeLog 2012-09-11 14:47:21 UTC (rev 128185)
+++ trunk/Tools/ChangeLog 2012-09-11 14:49:53 UTC (rev 128186)
@@ -1,3 +1,21 @@
+2012-09-11 Mikhail Pozdnyakov <[email protected]>
+
+ [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
+ https://bugs.webkit.org/show_bug.cgi?id=96269
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Exported missing testRunner.setSpatialNavigationEnabled() method.
+
+ * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
+ * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
+ (WTR::InjectedBundle::beginTesting):
+ * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+ (WTR::TestRunner::setSpatialNavigationEnabled):
+ (WTR):
+ * WebKitTestRunner/InjectedBundle/TestRunner.h:
+ (TestRunner):
+
2012-09-11 Philippe Liard <[email protected]>
Support LayoutTests on non-rooted devices for Chromium Android.
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl (128185 => 128186)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl 2012-09-11 14:47:21 UTC (rev 128185)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl 2012-09-11 14:49:53 UTC (rev 128186)
@@ -68,6 +68,7 @@
void setUserStyleSheetEnabled(in boolean value);
void setUserStyleSheetLocation(in DOMString location);
void setMinimumTimerInterval(in double interval); // Interval specified in seconds.
+ void setSpatialNavigationEnabled(in boolean value);
// Special DOM functions.
void clearBackForwardList();
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp (128185 => 128186)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2012-09-11 14:47:21 UTC (rev 128185)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2012-09-11 14:49:53 UTC (rev 128186)
@@ -241,6 +241,7 @@
WKBundleSetFrameFlatteningEnabled(m_bundle, m_pageGroup, false);
WKBundleSetMinimumLogicalFontSize(m_bundle, m_pageGroup, 9);
WKBundleSetMinimumTimerInterval(m_bundle, m_pageGroup, 0.010); // 10 milliseconds (DOMTimer::s_minDefaultTimerInterval)
+ WKBundleSetSpatialNavigationEnabled(m_bundle, m_pageGroup, false);
WKBundleRemoveAllUserContent(m_bundle, m_pageGroup);
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp (128185 => 128186)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2012-09-11 14:47:21 UTC (rev 128185)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2012-09-11 14:49:53 UTC (rev 128186)
@@ -688,6 +688,11 @@
WKBundleSetMinimumTimerInterval(InjectedBundle::shared().bundle(), InjectedBundle::shared().pageGroup(), seconds);
}
+void TestRunner::setSpatialNavigationEnabled(bool enabled)
+{
+ WKBundleSetSpatialNavigationEnabled(InjectedBundle::shared().bundle(), InjectedBundle::shared().pageGroup(), enabled);
+}
+
void TestRunner::grantWebNotificationPermission(JSStringRef origin)
{
WKRetainPtr<WKStringRef> originWK = toWK(origin);
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h (128185 => 128186)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h 2012-09-11 14:47:21 UTC (rev 128185)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h 2012-09-11 14:49:53 UTC (rev 128186)
@@ -107,6 +107,7 @@
void setUserStyleSheetEnabled(bool);
void setUserStyleSheetLocation(JSStringRef);
void setMinimumTimerInterval(double seconds); // Interval specified in seconds.
+ void setSpatialNavigationEnabled(bool);
// Special DOM functions.
JSValueRef computedStyleIncludingVisitedInfo(JSValueRef element);
