Title: [128189] trunk
- Revision
- 128189
- Author
- [email protected]
- Date
- 2012-09-11 08:12:28 -0700 (Tue, 11 Sep 2012)
Log Message
[Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
https://bugs.webkit.org/show_bug.cgi?id=91988
Patch by Luciano Wolf <[email protected]> on 2012-09-11
Reviewed by Kenneth Rohde Christiansen.
Tools:
Regular key events generated by Qt for the tab key fill both
keyCode and keyText, so we should do the same for our fake events.
* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::keyDown):
LayoutTests:
Unskip related tests.
* platform/qt-5.0-wk2/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (128188 => 128189)
--- trunk/LayoutTests/ChangeLog 2012-09-11 15:08:43 UTC (rev 128188)
+++ trunk/LayoutTests/ChangeLog 2012-09-11 15:12:28 UTC (rev 128189)
@@ -1,3 +1,14 @@
+2012-09-11 Luciano Wolf <[email protected]>
+
+ [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
+ https://bugs.webkit.org/show_bug.cgi?id=91988
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Unskip related tests.
+
+ * platform/qt-5.0-wk2/Skipped:
+
2012-09-11 Mikhail Pozdnyakov <[email protected]>
[WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
Modified: trunk/LayoutTests/platform/qt-5.0-wk2/Skipped (128188 => 128189)
--- trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-09-11 15:08:43 UTC (rev 128188)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-09-11 15:12:28 UTC (rev 128189)
@@ -446,11 +446,6 @@
fast/transforms/transformed-focused-text-input.html
editing/selection/14971.html
-# [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
-# https://bugs.webkit.org/show_bug.cgi?id=91988
-editing/inserting/typing-tab-designmode-forms.html
-editing/inserting/typing-tab-designmode.html
-
# Size of select is different when running DRT/WTR
fast/replaced/three-selects-break.html
Modified: trunk/Tools/ChangeLog (128188 => 128189)
--- trunk/Tools/ChangeLog 2012-09-11 15:08:43 UTC (rev 128188)
+++ trunk/Tools/ChangeLog 2012-09-11 15:12:28 UTC (rev 128189)
@@ -1,3 +1,16 @@
+2012-09-11 Luciano Wolf <[email protected]>
+
+ [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
+ https://bugs.webkit.org/show_bug.cgi?id=91988
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Regular key events generated by Qt for the tab key fill both
+ keyCode and keyText, so we should do the same for our fake events.
+
+ * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
+ (WTR::EventSenderProxy::keyDown):
+
2012-09-11 Mikhail Pozdnyakov <[email protected]>
[WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
Modified: trunk/Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp (128188 => 128189)
--- trunk/Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp 2012-09-11 15:08:43 UTC (rev 128188)
+++ trunk/Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp 2012-09-11 15:12:28 UTC (rev 128189)
@@ -131,7 +131,7 @@
code = Qt::Key_Tab;
if (modifiers == Qt::ShiftModifier)
code = Qt::Key_Backtab;
- keyText = QString();
+ keyText = QStringLiteral("\t");
} else if (code == KEYCODE_DEL || code == KEYCODE_BACKSPACE) {
code = Qt::Key_Backspace;
if (modifiers == Qt::AltModifier)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
