Title: [128213] trunk/Tools
- Revision
- 128213
- Author
- [email protected]
- Date
- 2012-09-11 11:50:13 -0700 (Tue, 11 Sep 2012)
Log Message
Garden-o-matic should ignore a wider variety of warnings in buildbot json
https://bugs.webkit.org/show_bug.cgi?id=96411
Reviewed by Adam Barth.
Previously only the exact string "warning" was treated as a warning
result. This patch treats any string with "warning" as a substring
as a warning (e.g., "warnings", as seen on the cr-win buildbots).
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js (128212 => 128213)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js 2012-09-11 18:42:55 UTC (rev 128212)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js 2012-09-11 18:50:13 UTC (rev 128213)
@@ -56,7 +56,8 @@
// FIXME: Do build.webkit.org bots output this marker when the tests fail to run?
return step.text.indexOf(kCrashedOrHungOutputMarker) != -1;
}
- return step.results[0] > 0 && step.text.indexOf('warning') == -1;
+ function isWarning(text) { return text.indexOf('warning') != -1; }
+ return step.results[0] > 0 && !step.text.some(isWarning);
}
function failingSteps(buildInfo)
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js (128212 => 128213)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js 2012-09-11 18:42:55 UTC (rev 128212)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js 2012-09-11 18:50:13 UTC (rev 128213)
@@ -541,7 +541,7 @@
"results": [1, []],
"statistics": {},
"step_number": 4,
- "text": ["extract_build", "warning"],
+ "text": ["extract_build", "warnings"],
"times": [1318366370.94771, 1318366404.552783],
"urls": {}
}, {
Modified: trunk/Tools/ChangeLog (128212 => 128213)
--- trunk/Tools/ChangeLog 2012-09-11 18:42:55 UTC (rev 128212)
+++ trunk/Tools/ChangeLog 2012-09-11 18:50:13 UTC (rev 128213)
@@ -1,3 +1,18 @@
+2012-09-11 Adam Klein <[email protected]>
+
+ Garden-o-matic should ignore a wider variety of warnings in buildbot json
+ https://bugs.webkit.org/show_bug.cgi?id=96411
+
+ Reviewed by Adam Barth.
+
+ Previously only the exact string "warning" was treated as a warning
+ result. This patch treats any string with "warning" as a substring
+ as a warning (e.g., "warnings", as seen on the cr-win buildbots).
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
+ (.):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
+
2012-09-11 Marcelo Lira <[email protected]>
Restore original value of mock scrollbars enabled in InternalSettings
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
