Title: [128221] trunk
- Revision
- 128221
- Author
- [email protected]
- Date
- 2012-09-11 13:34:08 -0700 (Tue, 11 Sep 2012)
Log Message
Unreviewed, manually rolling out r128175.
The patch is causing crashes in debug builds.
http://trac.webkit.org/changeset/128175
https://bugs.webkit.org/show_bug.cgi?id=96284
Source/WebCore:
* platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessage):
LayoutTests:
* http/tests/misc/non-utf8-header-name-expected.txt: Removed.
* http/tests/misc/non-utf8-header-name.php: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (128220 => 128221)
--- trunk/LayoutTests/ChangeLog 2012-09-11 20:14:51 UTC (rev 128220)
+++ trunk/LayoutTests/ChangeLog 2012-09-11 20:34:08 UTC (rev 128221)
@@ -1,3 +1,13 @@
+2012-09-11 Zan Dobersek <[email protected]>
+
+ Unreviewed, manually rolling out r128175.
+ The patch is causing crashes in debug builds.
+ http://trac.webkit.org/changeset/128175
+ https://bugs.webkit.org/show_bug.cgi?id=96284
+
+ * http/tests/misc/non-utf8-header-name-expected.txt: Removed.
+ * http/tests/misc/non-utf8-header-name.php: Removed.
+
2012-09-11 Adam Klein <[email protected]>
Unreviewed chromium gardening.
Deleted: trunk/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt (128220 => 128221)
--- trunk/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt 2012-09-11 20:14:51 UTC (rev 128220)
+++ trunk/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt 2012-09-11 20:34:08 UTC (rev 128221)
@@ -1 +0,0 @@
-Test for bug 96284: Non UTF-8 HTTP headers do not cause a crash.
Deleted: trunk/LayoutTests/http/tests/misc/non-utf8-header-name.php (128220 => 128221)
--- trunk/LayoutTests/http/tests/misc/non-utf8-header-name.php 2012-09-11 20:14:51 UTC (rev 128220)
+++ trunk/LayoutTests/http/tests/misc/non-utf8-header-name.php 2012-09-11 20:34:08 UTC (rev 128221)
@@ -1,9 +0,0 @@
-<?php
-header('HTTP/1.1 200 OK');
-header('\xC3: text/html');
-echo '<script>';
-echo ' if (window.testRunner)';
-echo ' testRunner.dumpAsText();';
-echo '</script>';
-echo '<p>Test for <a href="" 96284</a>: Non UTF-8 HTTP headers do not cause a crash.</p>';
-?>
Modified: trunk/Source/WebCore/ChangeLog (128220 => 128221)
--- trunk/Source/WebCore/ChangeLog 2012-09-11 20:14:51 UTC (rev 128220)
+++ trunk/Source/WebCore/ChangeLog 2012-09-11 20:34:08 UTC (rev 128221)
@@ -1,3 +1,13 @@
+2012-09-11 Zan Dobersek <[email protected]>
+
+ Unreviewed, manually rolling out r128175.
+ The patch is causing crashes in debug builds.
+ http://trac.webkit.org/changeset/128175
+ https://bugs.webkit.org/show_bug.cgi?id=96284
+
+ * platform/network/soup/ResourceResponseSoup.cpp:
+ (WebCore::ResourceResponse::updateFromSoupMessage):
+
2012-09-11 James Robinson <[email protected]>
Unreviewed, rolling out r128212.
Modified: trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp (128220 => 128221)
--- trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp 2012-09-11 20:14:51 UTC (rev 128220)
+++ trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp 2012-09-11 20:34:08 UTC (rev 128221)
@@ -69,7 +69,7 @@
soup_message_headers_iter_init(&headersIter, soupMessage->response_headers);
while (soup_message_headers_iter_next(&headersIter, &headerName, &headerValue))
- m_httpHeaderFields.set(String::fromUTF8WithLatin1Fallback(headerName, strlen(headerName)),
+ m_httpHeaderFields.set(String::fromUTF8(headerName),
String::fromUTF8WithLatin1Fallback(headerValue, strlen(headerValue)));
m_soupFlags = soup_message_get_flags(soupMessage);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
