Title: [128419] trunk/Tools
- Revision
- 128419
- Author
- [email protected]
- Date
- 2012-09-13 01:14:52 -0700 (Thu, 13 Sep 2012)
Log Message
[Qt][WK2] Memory leaks in Qt's TestRunner
https://bugs.webkit.org/show_bug.cgi?id=96603
Patch by Sudarsana Nagineni <[email protected]> on 2012-09-13
Reviewed by Csaba Osztrogonác.
Fix memory leaks in Qt's TestRunner code by adopting WKString
created with WKStringCreateWithUTF8CString().
* WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::TestController::initializeInjectedBundlePath):
(WTR::TestController::initializeTestPluginDirectory):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (128418 => 128419)
--- trunk/Tools/ChangeLog 2012-09-13 08:11:49 UTC (rev 128418)
+++ trunk/Tools/ChangeLog 2012-09-13 08:14:52 UTC (rev 128419)
@@ -1,3 +1,17 @@
+2012-09-13 Sudarsana Nagineni <[email protected]>
+
+ [Qt][WK2] Memory leaks in Qt's TestRunner
+ https://bugs.webkit.org/show_bug.cgi?id=96603
+
+ Reviewed by Csaba Osztrogonác.
+
+ Fix memory leaks in Qt's TestRunner code by adopting WKString
+ created with WKStringCreateWithUTF8CString().
+
+ * WebKitTestRunner/qt/TestControllerQt.cpp:
+ (WTR::TestController::initializeInjectedBundlePath):
+ (WTR::TestController::initializeTestPluginDirectory):
+
2012-09-13 Zan Dobersek <[email protected]>
[GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
Modified: trunk/Tools/WebKitTestRunner/qt/TestControllerQt.cpp (128418 => 128419)
--- trunk/Tools/WebKitTestRunner/qt/TestControllerQt.cpp 2012-09-13 08:11:49 UTC (rev 128418)
+++ trunk/Tools/WebKitTestRunner/qt/TestControllerQt.cpp 2012-09-13 08:14:52 UTC (rev 128419)
@@ -99,7 +99,7 @@
if (!isExistingLibrary(path))
qFatal("Cannot find the injected bundle at %s\n", qPrintable(path));
- m_injectedBundlePath = WKStringCreateWithQString(path);
+ m_injectedBundlePath.adopt(WKStringCreateWithQString(path));
}
void TestController::initializeTestPluginDirectory()
@@ -107,7 +107,7 @@
// FIXME: the test plugin cause some trouble for us, so we don't load it for the time being.
// See: https://bugs.webkit.org/show_bug.cgi?id=86620
- // m_testPluginDirectory = WKStringCreateWithUTF8CString(qgetenv("QTWEBKIT_PLUGIN_PATH").constData());
+ // m_testPluginDirectory.adopt(WKStringCreateWithUTF8CString(qgetenv("QTWEBKIT_PLUGIN_PATH").constData()));
}
void TestController::platformInitializeContext()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
