Title: [128470] trunk
Revision
128470
Author
[email protected]
Date
2012-09-13 08:31:12 -0700 (Thu, 13 Sep 2012)

Log Message

[CMake] Remove some redundant warning flags and enable a few more warnings.
https://bugs.webkit.org/show_bug.cgi?id=96654

Patch by Raphael Kubo da Costa <[email protected]> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

* Source/cmake/WebKitHelpers.cmake: Remove a few warning flags
which are already enabled by -Wall and -Wextra, remove -W which
looks useless and also enable a few more warnings by removing
their -Wno-foo counterparts which were present.

Modified Paths

Diff

Modified: trunk/ChangeLog (128469 => 128470)


--- trunk/ChangeLog	2012-09-13 15:27:39 UTC (rev 128469)
+++ trunk/ChangeLog	2012-09-13 15:31:12 UTC (rev 128470)
@@ -1,3 +1,15 @@
+2012-09-13  Raphael Kubo da Costa  <[email protected]>
+
+        [CMake] Remove some redundant warning flags and enable a few more warnings.
+        https://bugs.webkit.org/show_bug.cgi?id=96654
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        * Source/cmake/WebKitHelpers.cmake: Remove a few warning flags
+        which are already enabled by -Wall and -Wextra, remove -W which
+        looks useless and also enable a few more warnings by removing
+        their -Wno-foo counterparts which were present.
+
 2012-09-13  Tor Arne Vestbø  <[email protected]>
 
         [Qt] Ensure that QT is finalized before loading qt_module.prf

Modified: trunk/Source/cmake/WebKitHelpers.cmake (128469 => 128470)


--- trunk/Source/cmake/WebKitHelpers.cmake	2012-09-13 15:27:39 UTC (rev 128469)
+++ trunk/Source/cmake/WebKitHelpers.cmake	2012-09-13 15:31:12 UTC (rev 128470)
@@ -37,7 +37,7 @@
 
     # Enable warnings by default
     IF (NOT ${OPTION_IGNORECXX_WARNINGS})
-        SET(OLD_COMPILE_FLAGS "-W -DANOTHER_BRICK_IN_THE -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat -Wformat-security -Wmissing-format-attribute -Wno-format-y2k -Wno-parentheses -Wno-unused-parameter -Wpointer-arith  -Wreturn-type -Wundef -Wwrite-strings ${OLD_COMPILE_FLAGS}")
+        SET(OLD_COMPILE_FLAGS "-DANOTHER_BRICK_IN_THE -Wall -Wextra -Wcast-align -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wundef -Wwrite-strings ${OLD_COMPILE_FLAGS}")
     ENDIF ()
 
     # Disable C++0x compat warnings for GCC >= 4.6.0 until we build
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to