Title: [128501] trunk/Source/WebKit/chromium
- Revision
- 128501
- Author
- [email protected]
- Date
- 2012-09-13 13:26:24 -0700 (Thu, 13 Sep 2012)
Log Message
[chromium] alter fling animation parameters.
https://bugs.webkit.org/show_bug.cgi?id=96666
Reviewed by Adrienne Walker.
Corrected the test to be non-fragile in the presence of altered fling
curve parameters.
* tests/PlatformGestureCurveTest.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (128500 => 128501)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-13 20:23:13 UTC (rev 128500)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-13 20:26:24 UTC (rev 128501)
@@ -1,3 +1,15 @@
+2012-09-13 Robert Kroeger <[email protected]>
+
+ [chromium] alter fling animation parameters.
+ https://bugs.webkit.org/show_bug.cgi?id=96666
+
+ Reviewed by Adrienne Walker.
+
+ Corrected the test to be non-fragile in the presence of altered fling
+ curve parameters.
+
+ * tests/PlatformGestureCurveTest.cpp:
+
2012-09-13 Sheriff Bot <[email protected]>
Unreviewed, rolling out r128489.
Modified: trunk/Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp (128500 => 128501)
--- trunk/Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp 2012-09-13 20:23:13 UTC (rev 128500)
+++ trunk/Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp 2012-09-13 20:26:24 UTC (rev 128501)
@@ -99,10 +99,12 @@
{
double initialVelocity = 5000;
MockPlatformGestureCurveTarget target;
- OwnPtr<ActivePlatformGestureAnimation> animation = ActivePlatformGestureAnimation::create(TouchFlingPlatformGestureCurve::createForTouchPad(FloatPoint(initialVelocity, 0)), &target);
+ // Explicitly parametrized to make test non-brittle in face of
+ // parameter changes.
+ OwnPtr<ActivePlatformGestureAnimation> animation = ActivePlatformGestureAnimation::create(TouchFlingPlatformGestureCurve::create(FloatPoint(initialVelocity, 0), -5.70762e+03, 1.72e+02, 3.7e+00, 1.3), &target);
- // Note: the expectations below are dependent on the value of sigma hard-coded in the curve parameters.
- // If the parameters change, then the tests values/expectations will need to be updated.
+ // Note: the expectations below are dependent on the curve parameters hard
+ // coded into the create call above.
EXPECT_TRUE(animation->animate(0));
EXPECT_TRUE(animation->animate(0.25));
EXPECT_TRUE(animation->animate(0.45)); // Use non-uniform tick spacing.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
