Title: [128602] trunk
- Revision
- 128602
- Author
- [email protected]
- Date
- 2012-09-14 06:19:36 -0700 (Fri, 14 Sep 2012)
Log Message
EventSendingController::keyDown does not support non-array modifier arguments
https://bugs.webkit.org/show_bug.cgi?id=96727
Patch by Sudarsana Nagineni <[email protected]> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.
Tools:
Add support for handling a string as modifier argument to
EventSendingController::keyDown.
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::parseModifierArray):
LayoutTests:
Unskip passing test fast/forms/legend-access-key.html
* platform/efl-wk2/TestExpectations:
* platform/gtk-wk2/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (128601 => 128602)
--- trunk/LayoutTests/ChangeLog 2012-09-14 13:10:37 UTC (rev 128601)
+++ trunk/LayoutTests/ChangeLog 2012-09-14 13:19:36 UTC (rev 128602)
@@ -1,3 +1,15 @@
+2012-09-14 Sudarsana Nagineni <[email protected]>
+
+ EventSendingController::keyDown does not support non-array modifier arguments
+ https://bugs.webkit.org/show_bug.cgi?id=96727
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Unskip passing test fast/forms/legend-access-key.html
+
+ * platform/efl-wk2/TestExpectations:
+ * platform/gtk-wk2/Skipped:
+
2012-09-14 Vsevolod Vlasov <[email protected]>
Unreviewed skipping failing test.
Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (128601 => 128602)
--- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-14 13:10:37 UTC (rev 128601)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-14 13:19:36 UTC (rev 128602)
@@ -197,7 +197,6 @@
BUGWKEFL : editing/input/emacs-ctrl-o.html = TEXT
BUGWKEFL : fast/block/float/float-in-float-hit-testing.html = TEXT
BUGWKEFL : fast/dom/Window/mozilla-focus-blur.html = TEXT
-BUGWKEFL : fast/forms/legend-access-key.html = TEXT
BUGWKEFL : fast/forms/select-writing-direction-natural.html = TEXT
BUGWKEFL : fast/frames/flattening/iframe-tiny.html = TEXT
BUGWKEFL : fast/replaced/no-focus-ring-embed.html = TEXT
Modified: trunk/LayoutTests/platform/gtk-wk2/Skipped (128601 => 128602)
--- trunk/LayoutTests/platform/gtk-wk2/Skipped 2012-09-14 13:10:37 UTC (rev 128601)
+++ trunk/LayoutTests/platform/gtk-wk2/Skipped 2012-09-14 13:19:36 UTC (rev 128602)
@@ -83,7 +83,6 @@
fast/forms/select-type-ahead-non-latin.html
fast/forms/listbox-typeahead-cyrillic.html
fast/forms/listbox-typeahead-greek.html
-fast/forms/legend-access-key.html
http/tests/xmlhttprequest/workers/abort-exception-assert.html
platform/gtk/fast/forms/menulist-typeahead-find.html
plugins/document-open.html
Modified: trunk/Tools/ChangeLog (128601 => 128602)
--- trunk/Tools/ChangeLog 2012-09-14 13:10:37 UTC (rev 128601)
+++ trunk/Tools/ChangeLog 2012-09-14 13:19:36 UTC (rev 128602)
@@ -1,3 +1,16 @@
+2012-09-14 Sudarsana Nagineni <[email protected]>
+
+ EventSendingController::keyDown does not support non-array modifier arguments
+ https://bugs.webkit.org/show_bug.cgi?id=96727
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Add support for handling a string as modifier argument to
+ EventSendingController::keyDown.
+
+ * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
+ (WTR::parseModifierArray):
+
2012-09-14 Mikhail Pozdnyakov <[email protected]>
WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp (128601 => 128602)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp 2012-09-14 13:10:37 UTC (rev 128601)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp 2012-09-14 13:19:36 UTC (rev 128602)
@@ -74,6 +74,13 @@
{
if (!arrayValue)
return 0;
+
+ // The value may either be a string with a single modifier or an array of modifiers.
+ if (JSValueIsString(context, arrayValue)) {
+ JSRetainPtr<JSStringRef> string(Adopt, JSValueToStringCopy(context, arrayValue, 0));
+ return parseModifier(string.get());
+ }
+
if (!JSValueIsObject(context, arrayValue))
return 0;
JSObjectRef array = const_cast<JSObjectRef>(arrayValue);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
